-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI jobs that broke as a result of windows-latest
being upgraded to Windows Server 2022
#917
Conversation
d64e51d
to
d1dd1ff
Compare
@github/codeql-action-reviewers Since this PR changes a few jobs from |
Build tracing currently does not support Windows 2022, so use `windows-2019` instead of`windows-latest`.
e43cec9
to
2ebc770
Compare
2ebc770
to
8dd2b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably affect some customers who are on windows-latest. We should probably add a change log entry for this. Or maybe even in the readme.
Yeah...this line needs to change, or at least add a caveat:
Line 42 in a57642e
# CodeQL runs on ubuntu-latest, windows-latest, and macos-latest |
I thought we'd already done a changelog note for Windows Server 2022, but seemingly we only did one for the CLI. I agree we should do a changelog and update the readme, but I suggest we do so in a separate PR so we can get the checks fixed on |
windows-latest
being upgraded to Windows Server 2022windows-latest
being upgraded to Windows Server 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine by me. A changelog note as well as making a note in the README in a separate PR. Thanks for getting this done.
Required checks updated. |
windows-latest
is currently migrating from an image based on Windows Server 2019 to an image based on Windows Server 2022. This breaks some of our CI jobs for two reasons:windows-2022
image.This PR addresses (1) by moving relevant jobs to use the
windows-2019
image and (2) by fixing a typo that preventedsetup-python
from downloading and installing Python 2 when it's not already in the Actions VM image.Merge / deployment checklist