-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debugging output #861
Conversation
That's wild. Looks like failures on Python 2 on macos. Rerunning on main to see if this is a general problem: https://github.com/github/codeql-action/actions/runs/1633534088 |
Yep. Same jobs are failing on main. This must be related to some changes to the python 2 version that is bundled in the virtual environment. Will look deeper when I am back at work. |
Hmm, strange. I can't imagine this change causing any test failures so it's probably something that is failing on main too. Maybe a change to the Python version in the Mac OS Actions image is causing the test failures? Edit: yep, what you said while I typed that haha |
Here is the most recent passing job: https://github.com/github/codeql-action/runs/4668380714?check_suite_focus=true You can see that the image used in the passing workflow is the same as the one used in the failing workflow. So, it must be some sort of python transitive dependency that has changed. This will be fun to track down. |
Difference is the version of virtualenv. For the passing job, it is 20.11.2. For the failing job, it is 20.12.1. So, looks like we need to force [email protected] for python 2 tests. |
Let's see if this works. #862 |
Sweet, thanks for fixing that! |
Looks like I accidentally committed some debugging output when I wrote this part of our CI. This PR removes it.
Merge / deployment checklist