Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax in a workflow #790

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix syntax in a workflow #790

merged 1 commit into from
Oct 22, 2021

Conversation

edoardopirovano
Copy link
Contributor

Attempts to fix the logic added in #789 since some runs appear to not be doing the right thing, e.g. https://github.com/github/codeql-action/runs/3977974129?check_suite_focus=true

@edoardopirovano edoardopirovano requested a review from a team as a code owner October 22, 2021 16:41
@edoardopirovano edoardopirovano mentioned this pull request Oct 22, 2021
Merged
3 tasks
adityasharad
adityasharad approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, the if block is special in that it doesn't require ${{ }}.

@cklin cklin added the Update dependencies Trigger PR workflow to update dependencies label Oct 22, 2021
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Oct 22, 2021
aeisenberg
aeisenberg reviewed Oct 22, 2021
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. If we wanted to keep the optional ${{ ... }} I think we'd want it to wrap the entire expression, not just part of it.

@edoardopirovano
Copy link
Contributor Author

This will need force merging as it is running the broken workflow from main.

@adityasharad adityasharad merged commit c89d9bd into github:main Oct 22, 2021
@github-actions github-actions bot mentioned this pull request Oct 25, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg left review comments

@adityasharad adityasharad adityasharad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edoardopirovano @aeisenberg @adityasharad @cklin