Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old baseline LoC injection #715

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

edoardopirovano
Copy link
Contributor

This PR removes the old-style injection of baseline lines of code that was needed during a transition period while Code Scanning was updated to look for the lines of code in the new location (which was added in #624). The old way was never shipped in GHES, so we do not need to worry about compatibility with old versions and can remove this now.

cc. @rneatherway

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 26, 2021 12:48
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but perhaps a quick look by @robertbrignull or @rneatherway would be good.

@aeisenberg aeisenberg enabled auto-merge September 1, 2021 14:27
@aeisenberg aeisenberg merged commit f9b0b9c into github:main Sep 1, 2021
@github-actions github-actions bot mentioned this pull request Sep 6, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants