Remove artifact_v4_upgrade
feature flag logic and related PR checks
#2634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reminded that we can set the value in the API response to be
true
for old versions of the CodeQL Action; once that change is in, this PR can be merged.The PR removes all mention of the feature flag, so the new artifact dependency will always be used except on GHES.
The
CODEQL_ACTION_ARTIFACT_V4_UPGRADE
environment variable is now deprecated as well so it is removed from the PR checks that included it. Thedebug-artifacts-legacy
PR check, that makes sure that the deprecated legacy version of the client works, is now also removed as we no longer can setCODEQL_ACTION_ARTIFACT_V4_UPGRADE
to false.Merge / deployment checklist