Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove artifact_v4_upgrade feature flag logic and related PR checks #2634

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

angelapwen
Copy link
Contributor

I was reminded that we can set the value in the API response to be true for old versions of the CodeQL Action; once that change is in, this PR can be merged.

The PR removes all mention of the feature flag, so the new artifact dependency will always be used except on GHES.

The CODEQL_ACTION_ARTIFACT_V4_UPGRADE environment variable is now deprecated as well so it is removed from the PR checks that included it. The debug-artifacts-legacy PR check, that makes sure that the deprecated legacy version of the client works, is now also removed as we no longer can set CODEQL_ACTION_ARTIFACT_V4_UPGRADE to false.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner December 4, 2024 20:08
@angelapwen
Copy link
Contributor Author

I will merge this once the monolith PR change is deployed.

@angelapwen angelapwen merged commit 6f9e628 into main Dec 6, 2024
265 checks passed
@angelapwen angelapwen deleted the angelapwen/stop-using-artifact-flag branch December 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants