Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature flag to use a bundle compressed using Zstandard when setting up the default tools #2502

Merged
merged 16 commits into from
Sep 27, 2024

Conversation

henrymercer
Copy link
Contributor

This PR adds a feature flag to download a CodeQL Bundle compressed using Zstandard when setting up the default tools.

If we determine that tar is new enough, we will download the zstd-compressed bundle.

We add a fallback mechanism: if setting up the zstd-compressed bundle fails, we will fall back to the gzip-compressed bundle.

We add PR checks to validate both setting up a zstd-compressed bundle when the feature flag is enabled, and the fallback mechanism.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 23, 2024 22:08
pr-checks/checks/zstd-bundle-fallback.yml Outdated Show resolved Hide resolved
pr-checks/checks/zstd-bundle.yml Show resolved Hide resolved
src/setup-codeql.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrymercer henrymercer merged commit 2617ff2 into main Sep 27, 2024
268 checks passed
@henrymercer henrymercer deleted the henrymercer/zstd-experiment branch September 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants