-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using zstd-compressed nightly bundles #2442
Conversation
4b5b9e6
to
7ce060f
Compare
Using the downloaded path is unreliable since we may have removed the file extension.
7ce060f
to
27dbb1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of questions:
- is there a reason we're only supporting for nightly bundles so far? (maybe I've missed the context behind that)
- should we expose this in an
experimental
changenote or will we do that once we've deemed the experiment a success?
Thanks for the review!
Only that we haven't had a stable release with a zstd bundle yet. My thinking was that it would be easier to write and test the functionality for stable versions once we have a stable zstd bundle.
I was thinking no since this only applies to nightly bundles which we haven't advertised before, but I don't feel strongly about it. |
When we're confident about this being a positive improvement, we will go through a proper release channel just to make sure we put out a changelog note and update documentation. |
We are currently experimenting with using bundles compressed using Zstandard (zstd) rather than gzip to potentially save a significant chunk of the time we spend extracting the bundle. This could lead to a noticeable analysis speedup, particularly for small codebases where fixed costs represent a higher proportion of the total runtime.
This PR is one of the first steps. Specifically:
tools
input toinit
tar xz
,x
for extract,z
for gzip, we just runtar x
.Merge / deployment checklist