Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash syntax #2331

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix bash syntax #2331

merged 1 commit into from
Jun 12, 2024

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Jun 12, 2024

This should stop

.github/workflows/script/update-node-modules.sh: line 1: [: missing `]'

@igfoo
Fix bash syntax
b0944a2 
This should stop

    .github/workflows/script/update-node-modules.sh: line 1: [: missing `]'
@igfoo igfoo requested a review from a team as a code owner June 12, 2024 11:56
henrymercer
henrymercer approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My understanding is that we could also use double-brackets, but that's less POSIX-compliant.

@igfoo igfoo enabled auto-merge June 12, 2024 12:14
@igfoo igfoo merged commit 945bb87 into main Jun 12, 2024
296 checks passed
@igfoo igfoo deleted the igfoo/bash branch June 12, 2024 12:40
This was referenced Jun 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igfoo @henrymercer