Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tracking of autobuild errors #2198

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Mar 14, 2024

Improve the way we surface errors while automatically attempting to build code, particularly in circumstances where the autobuilder doesn't produce diagnostic information.

Specifically, extract just the [ERROR] part of the stderr stream, and link users to the troubleshooting page in the docs.

Also mark Maven and Gradle build failures as configuration errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner March 14, 2024 17:59
nickfyson
nickfyson previously approved these changes Mar 14, 2024
Copy link
Contributor

@nickfyson nickfyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cli-errors.ts Outdated Show resolved Hide resolved
src/cli-errors.ts Outdated Show resolved Hide resolved
nickfyson
nickfyson previously approved these changes Mar 15, 2024
@henrymercer henrymercer merged commit 1ecc277 into main Mar 15, 2024
297 checks passed
@henrymercer henrymercer deleted the henrymercer/improve-tracking-autobuild-errors branch March 15, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants