Python: Don't install deps by default for all users #2031
Conversation
|
I think we can ignore |
Co-authored-by: Andrew Eisenberg <[email protected]>
|
LGTM! I'll avoid approving this until you move this out of draft mode. |
To make it more clear what feature is being removed in the future
| @@ -6,6 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the | |||
|
|
|||
| ## [UNRELEASED] | |||
|
|
|||
| - We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting `CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false` in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. [#2031](https://github.com/github/codeql-action/pull/2031) | |||
There was a problem hiding this comment.
[Non-blocking] Currently we disable Python dependency installation for CodeQL v2.16.0 and later, however the Action supports CodeQL versions all the way back to 2.11.6. Do we plan to keep supporting Python dependency installation for old CLIs in the Action until support for v2.15.5 is deprecated in about a year from now?
There was a problem hiding this comment.
I had hoped to be able delete the python-setup folder and all the logic for dependency installation soon, but let's discuss this aspect some more 👍
There was a problem hiding this comment.
👍 We can always start applying this to earlier CLI versions later on. Happy to discuss!
Merge / deployment checklist