Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable kotlin tests #1939

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Re-enable kotlin tests #1939

merged 7 commits into from
Jun 17, 2024

Conversation

aeisenberg
Copy link
Contributor

Reverts #1473

@aeisenberg aeisenberg requested a review from a team as a code owner October 10, 2023 23:09
@aeisenberg
Copy link
Contributor Author

Hmmm...now it's failing, but because there's an even newer version of kotlin. We are going to need to choose a specific version of kotlin based on the version of the CLI.

@aeisenberg aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch 4 times, most recently from a572e6d to c5f043e Compare October 13, 2023 22:20
Change the `prepare-test` action to conditionally setup kotlin.
@aeisenberg aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from c5f043e to fcf7c47 Compare October 13, 2023 22:25
@aeisenberg aeisenberg marked this pull request as draft November 14, 2023 18:22
@aeisenberg
Copy link
Contributor Author

Converting to draft mode since I won't be able to work on this. If someone else wants to pick it up, please do so.

@aeisenberg
Copy link
Contributor Author

Not going to be able to get to this.

@aeisenberg aeisenberg closed this Feb 2, 2024
@aeisenberg aeisenberg reopened this Apr 1, 2024
@aeisenberg aeisenberg closed this Jun 13, 2024
@aeisenberg aeisenberg reopened this Jun 14, 2024
@aeisenberg aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from 11b4852 to dd6e97c Compare June 14, 2024 20:46
@aeisenberg aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from dd6e97c to a449977 Compare June 14, 2024 21:17
@aeisenberg aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch 2 times, most recently from 1682ca4 to 7512620 Compare June 14, 2024 22:19
@aeisenberg aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from 7512620 to 31a716b Compare June 14, 2024 22:27
@aeisenberg aeisenberg marked this pull request as ready for review June 14, 2024 22:36
@aeisenberg
Copy link
Contributor Author

This should now be working properly. The version of kotlin is fixed to 1.8.21. We can consider upgrading the version in the future, or even running against multiple versions if we like.

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting back to this!! ✨

@aeisenberg aeisenberg merged commit 35619fb into main Jun 17, 2024
601 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/enable-kotlin-tests branch June 17, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants