Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scaling reserved RAM on GHES #1866

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Sep 5, 2023

We have completed our experiments with scaling reserved RAM and this feature is now ready to roll out to GHES.

This PR deprecates the feature flag, and also adds an environment variable CODEQL_ACTION_SCALING_RESERVED_RAM_PERCENTAGE. We can use this environment variable to customize the percentage of scaling reserved RAM. Repos can opt out of scaling RAM by setting it to zero, and setting it to any other integer between 1 and 100 lets us fine-tune the RAM calculation.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 5, 2023 11:21
@henrymercer henrymercer requested a review from dbartol September 6, 2023 17:12
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment about fixing up the changelog note!

CHANGELOG.md Outdated Show resolved Hide resolved
@henrymercer henrymercer merged commit 4764dce into main Sep 7, 2023
344 checks passed
@henrymercer henrymercer deleted the henrymercer/enable-scaling-reserved-ram-ghes branch September 7, 2023 18:38
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants