Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-release trigger for update-bundle action #1648

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix pre-release trigger for update-bundle action #1648

merged 1 commit into from
Apr 14, 2023

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Apr 14, 2023 •
edited
Loading

This PR switches the update-bundle release trigger from prereleased to published because the former has been documented not to work.

From https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release:

Note: The prereleased type will not trigger for pre-releases published from draft releases, but the published type will trigger. If you want a workflow to run when stable and pre-releases publish, subscribe to published instead of released and prereleased.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@cklin
Fix pre-release trigger for update-bundle action
ae24b75 
This PR switches the update-bundle release trigger from `prereleased` to `published` because the former has been documented not to work.

From https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release:

> Note: The prereleased type will not trigger for pre-releases published from draft releases, but the published type will trigger. If you want a workflow to run when stable and pre-releases publish, subscribe to published instead of released and prereleased.
@cklin cklin requested a review from a team as a code owner April 14, 2023 21:51
angelapwen
angelapwen approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's not intuitive at all! Thank you for catching this 😄

@cklin cklin merged commit be2b53b into main Apr 14, 2023
@cklin cklin deleted the cklin/update-bundle-trigger branch April 14, 2023 22:11
@cklin
Copy link
Contributor Author

cklin commented Apr 14, 2023

cc @henrymercer

@henrymercer henrymercer mentioned this pull request Apr 18, 2023
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Apr 21, 2023
Merged
6 tasks
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2023
Open
@aliscco aliscco mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cklin @angelapwen