Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values to feature flags #1567

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

aeisenberg
Copy link
Contributor

This changes adds default values to feature flags. These default values will be used whenever the full set of feature flags are not available (for example on GHES or if the flag request fails).

The goal is to enable cli config parsing on GHES without removing the feature flag on dotcom.

This changes adds default values to feature flags. These default values
will be used whenever the full set of feature flags are not available
(for example on GHES or if the flag request fails).

The goal is to enable cli config parsing on GHES without removing the
feature flag on dotcom.
@aeisenberg aeisenberg requested a review from a team as a code owner March 8, 2023 00:25
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@aeisenberg aeisenberg merged commit f13b180 into main Mar 8, 2023
@aeisenberg aeisenberg deleted the aeisenberg/config-parsing-ghes branch March 8, 2023 17:44
@github-actions github-actions bot mentioned this pull request Mar 10, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants