Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add capability to filter queries #1098" #1111

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jun 21, 2022

#1098
This reverts commit 777b778.
This reverts commit 59ca9b5.
This reverts commit eec34d5.
This reverts commit 40b2800.

The standard github tooling for reverting did not work since the full changes were split across two PRs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner June 21, 2022 19:15
@aeisenberg aeisenberg removed the request for review from a team June 21, 2022 19:16
@aeisenberg aeisenberg marked this pull request as draft June 21, 2022 19:16
@aeisenberg aeisenberg force-pushed the aeisenberg/revert-1098 branch from 8ff3367 to 2435647 Compare June 21, 2022 19:20
@aeisenberg aeisenberg marked this pull request as ready for review June 21, 2022 19:59
@aeisenberg aeisenberg requested a review from a team June 21, 2022 19:59
@edoardopirovano
Copy link
Contributor

Should we add a changenote saying we reverted? I think the original PR had one.

@aeisenberg
Copy link
Contributor Author

Going to remove the changelog entry since the feature isn't documented anywhere else. This will cause merge conflicts in the release process, but I can handle them manually.

#1098
This reverts commit 777b778.
This reverts commit 59ca9b5.
This reverts commit eec34d5.
This reverts commit 40b2800.
@aeisenberg aeisenberg force-pushed the aeisenberg/revert-1098 branch from 2435647 to 99d4397 Compare June 21, 2022 20:49
@aeisenberg aeisenberg enabled auto-merge June 21, 2022 20:49
@aeisenberg aeisenberg merged commit 2e0c6ca into main Jun 21, 2022
@aeisenberg aeisenberg deleted the aeisenberg/revert-1098 branch June 21, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants