Merge pull request #2340 from github/henrymercer/code-quality-improve…

…ments Miscellaneous code quality improvements
github · Jun 14, 2024 · bd2ebac · bd2ebac
2 parents 3990b56 + cf20090
commit bd2ebac
Show file tree

Hide file tree

Showing 55 changed files with 209 additions and 181 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -41,29 +41,23 @@
             "ignoreTemplateLiterals": true
         }],
         "no-async-foreach/no-async-foreach": "error",
-        "no-console": "off",
         "no-sequences": "error",
         "no-shadow": "off",
-        "@typescript-eslint/no-shadow": ["error"],
+        "@typescript-eslint/no-shadow": "error",
         "one-var": ["error", "never"]
     },
     "overrides": [{
         // "temporarily downgraded during transition to eslint
         "files": "**",
         "rules": {
-            "@typescript-eslint/ban-types": "off",
-            "@typescript-eslint/explicit-module-boundary-types": "off",
             "@typescript-eslint/no-explicit-any": "off",
             "@typescript-eslint/no-unsafe-assignment": "off",
-            "@typescript-eslint/no-unsafe-call": "off",
             "@typescript-eslint/no-unsafe-member-access": "off",
-            "@typescript-eslint/no-unsafe-return": "off",
             "@typescript-eslint/no-var-requires": "off",
             "@typescript-eslint/prefer-regexp-exec": "off",
             "@typescript-eslint/require-await": "off",
             "@typescript-eslint/restrict-template-expressions": "off",
-            "func-style": "off",
-            "sort-imports": "off"
+            "func-style": "off"
         }
     }],
     "settings": {

diff --git a/lib/analyze-action-post-helper.js.map b/lib/analyze-action-post-helper.js.map
diff --git a/lib/api-client.js b/lib/api-client.js
diff --git a/lib/api-client.js.map b/lib/api-client.js.map
diff --git a/lib/codeql.js.map b/lib/codeql.js.map
diff --git a/lib/codeql.test.js b/lib/codeql.test.js
diff --git a/lib/codeql.test.js.map b/lib/codeql.test.js.map
diff --git a/lib/config-utils.js.map b/lib/config-utils.js.map
diff --git a/lib/database-upload.js b/lib/database-upload.js
diff --git a/lib/database-upload.js.map b/lib/database-upload.js.map