Merge pull request #1826 from github/henrymercer/increase-reserved-sc…

…aling-factor Increase scaling factor for reserved RAM to 5%
github · Aug 7, 2023 · 66dc883 · 66dc883
2 parents 1f63aba + 2203178
commit 66dc883
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/lib/util.js b/lib/util.js
diff --git a/lib/util.js.map b/lib/util.js.map
diff --git a/lib/util.test.js b/lib/util.test.js
diff --git a/lib/util.test.js.map b/lib/util.test.js.map
diff --git a/src/util.test.ts b/src/util.test.ts
@@ -53,14 +53,14 @@ const GET_MEMORY_FLAG_TESTS = [
     totalMemoryMb: 64 * 1024,
     platform: "linux",
     expectedMemoryValue: 63 * 1024,
-    expectedMemoryValueWithScaling: 63078, // Math.floor(1024 * (64 - 1 - 0.025 * (64 - 8)))
+    expectedMemoryValueWithScaling: 61644, // Math.floor(1024 * (64 - 1 - 0.05 * (64 - 8)))
   },
   {
     input: undefined,
     totalMemoryMb: 64 * 1024,
     platform: "win32",
     expectedMemoryValue: 62.5 * 1024,
-    expectedMemoryValueWithScaling: 62566, // Math.floor(1024 * (64 - 1.5 - 0.025 * (64 - 8)))
+    expectedMemoryValueWithScaling: 61132, // Math.floor(1024 * (64 - 1.5 - 0.05 * (64 - 8)))
   },
 ];
 

diff --git a/src/util.ts b/src/util.ts
@@ -160,9 +160,9 @@ function getSystemReservedMemoryMegaBytes(
   const fixedAmount = 1024 * (platform === "win32" ? 1.5 : 1);
 
   if (isScalingReservedRamEnabled) {
-    // Reserve an additional 2.5% of the amount of memory above 8 GB, since the amount used by
-    // the kernel for page tables scales with the size of physical memory.
-    const scaledAmount = 0.025 * Math.max(totalMemoryMegaBytes - 8 * 1024, 0);
+    // Reserve an additional 5% of the amount of memory above 8 GB, since the amount used by the
+    // kernel for page tables scales with the size of physical memory.
+    const scaledAmount = 0.05 * Math.max(totalMemoryMegaBytes - 8 * 1024, 0);
     return fixedAmount + scaledAmount;
   } else {
     return fixedAmount;