Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw static url #1178

Closed
wants to merge 18 commits into from
Closed

Raw static url #1178

wants to merge 18 commits into from

Conversation

Dlurak
Copy link

@Dlurak Dlurak commented Jan 2, 2024

First of all I really want to apologize for all of those commits with horrific messages, but I needed them to run the GitHub-Actions.
The deployment to GitHub Pages now uses a GitHub-Action. Jekyll builds its static HTML-Files into an artifact and modified versions of the licenses are copied into the same artifact.
To prove that it works I created a own GitHub-Pages deployment which you can find here.

This solves #1177 .

@mlinksva
Copy link
Contributor

mlinksva commented Jan 3, 2024

Hmm, that does seem to work. I'm not sure I want to depart from the super simple default Pages deployment for this feature, let me think about it.

@Dlurak
Copy link
Author

Dlurak commented Jan 11, 2024

So, what your thoughts on this?

@Dlurak
Copy link
Author

Dlurak commented Jan 23, 2024

Your last comment was 3 weeks ago, did you already consider these changes?

@Dlurak
Copy link
Author

Dlurak commented Feb 5, 2024

@mlinksva have you forgotten about my pull request?
Just a quick reminder :)

Copy link

@Dioliode Dioliode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DioX

@Dlurak
Copy link
Author

Dlurak commented May 25, 2024

I once again want to ask what the current state of this pr is.
While I Understand that you @mlinksva surely have many responsibilities I find it unacceptable that you've ghosted me for nearly 6 months!
Given your affiliation with GitHub itself, I am particularly surprised by the absence of even a basic update. Effective communication and timely feedback are essential for maintaining a positive and productive environment for contributors. Without this, it becomes challenging for contributors like myself to remain motivated and engaged.
It gives the feeling that you don't even appreciate my efforts.

@Dlurak Dlurak closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants