Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE but please fix [GHSA-hp87-p4gw-j4gq] Unhandled exception in gopkg.in/yaml.v3 #353

Conversation

thediveo
Copy link

@thediveo thediveo commented May 31, 2022

This is not an improvement PR, do NOT merge it

This is a request to fix the broken GHSA

As there seems to be no other way to deal with a totally broken GitHub CVE, I'm afraid I need to give notice via an improvement request in the hope something hooman notices how messed up this GitHub CVE is ... albeit admittedly based on upstream.

  • The affected versions data is wrong, as it does not concern the widely used yaml.v2. This now causes an enormous number of false positives. See v3: panic "attempted to parse unknown event (please report): none" go-yaml/yaml#666 (comment).
  • yaml.v3 has (not only) incompatible unmarshalling changes that can silently break a lot of applications trying to upgrade from yaml.v2 to yaml.v3. For instance, at least in some situations the keys of unmarshalled maps change from interface{} to string. This and other API changes require lots of downstream changes, albeit yaml.v2 isn't vulnerable to the DoS attack that makes v3 panic'king.

@github-actions github-actions bot changed the base branch from main to thediveo/advisory-improvement-353 May 31, 2022 15:28
@thediveo thediveo changed the title [GHSA-hp87-p4gw-j4gq] Unhandled exception in gopkg.in/yaml.v3 DO NOT MERGE but please fix [GHSA-hp87-p4gw-j4gq] Unhandled exception in gopkg.in/yaml.v3 May 31, 2022
@dylan-tock
Copy link

#350 should handle this. But I would ask the @advisory-database folx to update this ASAP as I have repos that are incorrectly making my security folks farklempt.

@advisory-database advisory-database bot merged commit 42309f7 into thediveo/advisory-improvement-353 Jun 1, 2022
@advisory-database advisory-database bot deleted the thediveo-GHSA-hp87-p4gw-j4gq branch June 1, 2022 19:34
@advisory-database
Copy link
Contributor

Hi @thediveo! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@darakian
Copy link
Contributor

darakian commented Jun 1, 2022

@dylan-tock thanks for the fix PR and sorry all for the error.

@thediveo you're also welcome to make an issue in this repo if a PR isn't what you want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants