Add support for the lean comment format to the tokenizer #6625
+347
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Dec 6, 2023
eric-wieser
reviewed
Dec 6, 2023
eric-wieser
reviewed
Dec 6, 2023
eric-wieser
reviewed
Dec 6, 2023
eric-wieser
reviewed
Dec 7, 2023
eric-wieser
approved these changes
Dec 7, 2023
Co-authored-by: Eric Wieser <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the lean
/- ... -/comment format to the tokenizer.I discovered this was the cause of the problems with the classifier in #6616.
The only changes really looking at are those in
ext/linguist/tokenizer.landtest/test_tokenizer.rband the others are updated by flex base on the content oftest/test_tokenizer.rb.I know absolutely nothing about Lean, am barely competent in lex and slightly fluent in regex so there's probably scope for improvement here 😁 @eric-wieser @Alhadis can you please check my homework 🙇
Checklist: