Add Glimmer language #6556

gilest · 2023-09-22T22:08:28Z

Description

Adds support for Glimmer.js which will be the component authoring format of the next Edition of Ember.js.

Checklist:

I am adding a new language.
- The extension of the new language is used in hundreds of repositories on GitHub.com.
  - Search results for each extension:
    - .gjs search 1.3k files
    - .gts search 948 files
- I have included a real-world usage sample for all extensions added in this PR:
  - Sample source(s):
  - Sample license(s):
    - class.gjs - (https://github.com/discourse/discourse-ai) MIT
    - class.gts -(https://github.com/cardstack/cardstack) MIT
    - template-only.gts (https://github.com/EmberCrate/website) Apache 2.0
    - template-only.gjs (https://github.com/CrowdStrike/opensource.crowdstrike.com) MIT
- I have included a syntax highlighting grammar:
  - https://github.com/lifeart/vsc-ember-syntax – MIT
- I have added a color
  - Hex value: #F5835F
  - Rationale: Logo colour from https://glimmerjs.com/ at time of writing
- I have updated the heuristics to distinguish my language from others using the same extension.

script/add-grammar https://github.com/lifeart/vsc-ember-syntax Note: I removed `text.html.handlebars` from the `vsc-ember-syntax` in grammars.yml to (hopefully) avoid conficting with the existing Handlebars syntax which is also provided by `vsc-ember-syntax`.

…ber Image and Glimmer languages

lildude

Looks good from a quick scan but usage isn't high enough for either extension yet. I'll review this as I make each release.

vendor/licenses/git_submodule/vsc-ember-syntax.dep.yml

NullVoxPopuli · 2023-09-23T16:47:13Z

The extension usage is counted individually? Even though they're basically the same?

That'd be like treating js and ts separately?
(For context, this pr is for glimmer flavored JavaScript and glimmer flavored typescript)

lildude · 2023-09-23T17:46:04Z

The extension usage is counted individually? Even though they're basically the same?

Yup. This is documented. Once a language has an extension that meets the usage requirements, an override can be used for the others until such time as they’re popular enough for inclusion.

That'd be like treating js and ts separately?
(For context, this pr is for glimmer flavored JavaScript and glimmer flavored typescript)

We do as Typescript is technically not JavaScript. They’re also considered two separate languages as they use two different syntax highlighting grammars. Your grammar repo does too 😉

NullVoxPopuli · 2023-09-23T19:02:21Z

ok, thanks far clarifying. ❤️
I'm a little sad about this though, because the language grammars defer to to JS and TS for everything except for the stuff in between the <template> / </template> tags (which is the exact same for both extensions 💪 ).

We'll keep growing the adoption in the mean time tho!
I keep finding more folks every day that don't know about the new (approaching 2 years now (almost!)) syntax in our community. 🙃

NullVoxPopuli · 2023-09-30T19:21:36Z

For those following along, an update, we have ~2.4k files (1.3k of the javascript (about the same) and now 1.1k of the typescript (+ 200))

made a template for future updates

gjs + gts	gjs	gts
2.3k	1.5k	1k

with markdown

gjs + gts w/ md	gjs	gts
2.7k	1.7k	1.1k

wagenet · 2023-10-05T13:58:15Z

@lildude To clarify, it's 200 unique repos or 2,000 total files, right? How many unique repos are there so far?

lildude · 2023-10-05T14:23:20Z

@lildude To clarify, it's 200 unique repos or 2,000 total files, right? How many unique repos are there so far?

@wagenet your questions are answered by #5756 😁

NullVoxPopuli · 2023-10-09T16:23:40Z

For those following along, an update, we have ~2.6k files (1.6k of the javascript and now 1.1k of the typescript)

I'm not sure why querying for both files is less than the sum of the individual queries.

gjs + gts	gjs	gts
2.6k	1.6k	1.1k

with markdown

gjs + gts w/ md	gjs	gts
2.9k	1.8k	1.2k

lildude · 2023-10-09T16:38:51Z

I'm not sure why querying for both files is less than the sum of the individual queries.

I think this will probably be due to rounding of the numbers, but I'm only guessing; I'm not involved with the Search side of things.

As an aside, we really don't need these weekly updates. The PR won't be merged any quicker as I only merge feature additions when I make a new release which aligns approximately with the GitHub Enterprise Server releases. I also assess all pending popularity PRs at the same time.

There are also test failures that need addressing.

NullVoxPopuli · 2023-10-09T16:41:46Z

As an aside, we really don't need these weekly updates

fair enough! I was doing it more for the ember community, as they often ask -- but I suppose links to the queries is probably sufficient!

There are also test failures that need addressing.

@gilest can you take a look at those?

Because otherwise it fails the TestGrammars#test_readme_file_is_in_sync test. Not sure why this URL is considered not in sync. Maybe because of `ace_mode: javascript`?

vendor/README.md

gilest · 2023-10-12T21:12:37Z

Given that

.gjs extension seems like it will meet the acceptance criteria sooner
we may want to model Glimmer JS and Glimmer TS as two separate languages

I'm considering opening a new PR targeting Glimmer JS only

gilest · 2023-10-12T22:04:35Z

Closed in favour of #6578

Will stand up a separate PR for the TS language later on

gilest added 7 commits September 20, 2023 09:05

chore: add Glimmer to languages

d01db48

chore: add Glimmer samples

c45a58e

chore: generate language id for Glimmer

d08c018

chore: added a naive heuristic to disambiguate .gts files between Ger…

555c882

…ber Image and Glimmer languages

test: add heuristic test for gts files

7ab0d9f

chore: correct vendor readme entry for Glimmer

daec167

gilest requested a review from a team as a code owner September 22, 2023 22:08

gilest mentioned this pull request Sep 22, 2023

Add gjs/gts highlighting to GitHub ember-cli/ember-template-imports#123

Closed

lildude reviewed Sep 23, 2023

View reviewed changes

vendor/licenses/git_submodule/vsc-ember-syntax.dep.yml Outdated Show resolved Hide resolved

Update vendor/licenses/git_submodule/vsc-ember-syntax.dep.yml

9a525d5

github-linguist deleted a comment from XoL1507 Sep 29, 2023

revert: correct vendor readme entry for Glimmer

86e12f7

Because otherwise it fails the TestGrammars#test_readme_file_is_in_sync test. Not sure why this URL is considered not in sync. Maybe because of `ace_mode: javascript`?

lildude reviewed Oct 10, 2023

View reviewed changes

vendor/README.md Show resolved Hide resolved

gilest closed this Oct 12, 2023

github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Glimmer language #6556

Add Glimmer language #6556

gilest commented Sep 22, 2023

lildude left a comment •

edited

Loading

NullVoxPopuli commented Sep 23, 2023

lildude commented Sep 23, 2023 •

edited

Loading

NullVoxPopuli commented Sep 23, 2023 •

edited

Loading

NullVoxPopuli commented Sep 30, 2023 •

edited

Loading

wagenet commented Oct 5, 2023

lildude commented Oct 5, 2023

NullVoxPopuli commented Oct 9, 2023

lildude commented Oct 9, 2023

NullVoxPopuli commented Oct 9, 2023

gilest commented Oct 12, 2023

gilest commented Oct 12, 2023

Add Glimmer language #6556

Add Glimmer language #6556

Conversation

gilest commented Sep 22, 2023

Description

Checklist:

lildude left a comment • edited Loading

Choose a reason for hiding this comment

NullVoxPopuli commented Sep 23, 2023

lildude commented Sep 23, 2023 • edited Loading

NullVoxPopuli commented Sep 23, 2023 • edited Loading

NullVoxPopuli commented Sep 30, 2023 • edited Loading

wagenet commented Oct 5, 2023

lildude commented Oct 5, 2023

NullVoxPopuli commented Oct 9, 2023

lildude commented Oct 9, 2023

NullVoxPopuli commented Oct 9, 2023

gilest commented Oct 12, 2023

gilest commented Oct 12, 2023

lildude left a comment •

edited

Loading

lildude commented Sep 23, 2023 •

edited

Loading

NullVoxPopuli commented Sep 23, 2023 •

edited

Loading

NullVoxPopuli commented Sep 30, 2023 •

edited

Loading