-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stalebot #4311
Add stalebot #4311
Conversation
Flagging as stale. |
Wait, that's a really good idea. 14 hours of code review make John go loopy-loopy. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning on writing a Probot for that! I should have known someone already wrote one...
LGTM, even though I would have gone for a shorter time period before marking issues and PRs as stale.
Do we have a way to know which issues and pull requests will be affected when the pull request is merged? |
Yup. Just add If we go for 30 days with the current label choice, these issues and these PRs are affected. |
@lildude I haven't seen any changes in the issues and pull requests mentioned above. Are there still things that need to be configured to enable Probot, or will it only start labeling issues in 30 days? |
🤔 I don't think there's anything more to do after merging the PR. I'd expect things to come to life within the next 24 hours. |
And the storm begins... Maybe we could exclude issues and pull requests that have been assigned to one of us? Many of the now stale-marked issues are actually blocked because one of us (maintainers) needs to do something. |
Doesn't look like it has this functionality yet so the only thing to do would be use a label for the mo. Of course, the nudge should apply to us too - I often forget about my assigned PRs and issues 😀 |
Looks like we're in luck: probot/stale#172. |
Wow!!! What timing. Less than 24 hours after we started using stalebot 😁 |
@pchaigno has been doing a marvellous job of marking old issues and PRs stale but I feel this is a waste of his skills. Lets outsource this to a robot: stalebot.
The app has been added to the repo, so we just need to configure it - this PR.
I've gone with the default
daysUntil*
values as they seem like a good place to start.Template removed as it's not relevant.