Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proxy import to webhook entrypoint #198

Conversation

riley-kohler
Copy link
Contributor

@riley-kohler riley-kohler commented Jun 27, 2024

Pull Request

Proposed Changes

Adds the proxy import to the webhook entrypoint to fix proxy issues that were encountered when running the webhooks independently of the UI. Related to #134.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@riley-kohler riley-kohler requested a review from a team as a code owner June 27, 2024 20:09
@github-actions github-actions bot added the fix label Jun 27, 2024
Copy link
Contributor

@ajhenry ajhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can put this in something like middleware.ts. so it applies to everything 🤔 either way lgtm!

@ajhenry ajhenry merged commit 251c60a into github-community-projects:main Jul 1, 2024
11 checks passed
@riley-kohler riley-kohler deleted the add_proxy_import_to_webhook_entrypoint branch July 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants