Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination issues #177

Merged
merged 3 commits into from
Jun 18, 2024
Merged

fix: pagination issues #177

merged 3 commits into from
Jun 18, 2024

Conversation

sutterj
Copy link
Contributor

@sutterj sutterj commented Jun 13, 2024

Pull Request

Proposed Changes

  • Closes Pagination counting bug when mirrors are added or deleted #138
    • increase items per page
    • fix issue where body scrolled over header
    • fix issue with pagination count and search
    • due to limitations with primer table pagination, there is no way to fix the count when the
      last item on a table page is deleted, so when we run into this situation, reload the page

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

sutterj added 2 commits June 13, 2024 14:17
@sutterj
fix: pagination issues
cbceb3d 
- increase items per page
- fix issue where body scrolled over header
- fix issue with pagination count and search
- due to limitations with primer table pagination, there is no way to fix the count when the last item on a table page is deleted, so when we run into this situation, reload the page
@sutterj
fix: add comments
dd4abe0
@sutterj sutterj added the bug Something isn't working label Jun 13, 2024
@sutterj sutterj requested a review from a team as a code owner June 13, 2024 18:22
@sutterj sutterj changed the title Sutterj/pagination count fix: pagination issues Jun 13, 2024
zkoppert
zkoppert reviewed Jun 13, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the fix label Jun 13, 2024
zkoppert
zkoppert approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code side looks good. Would be great to have another reviewer test this out in the app. I don't have a local dev env setup to see this running yet.

ajhenry
ajhenry approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@ajhenry ajhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my end!

@sutterj sutterj merged commit b152466 into main Jun 18, 2024
12 checks passed
@sutterj sutterj deleted the sutterj/pagination-count branch June 18, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajhenry ajhenry ajhenry approved these changes

@zkoppert zkoppert zkoppert approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination counting bug when mirrors are added or deleted
3 participants
@sutterj @zkoppert @ajhenry