Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add button on unauth page #167

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat: add button on unauth page #167

merged 1 commit into from
Jun 12, 2024

Conversation

sutterj
Copy link
Contributor

@sutterj sutterj commented Jun 12, 2024 •
edited
Loading

Pull Request

Proposed Changes

Screenshot 2024-06-12 at 12 58 19 PM

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@sutterj
feat: add button on unauth page
53dd208 
- user currently has no action from unauth page
- this button takes them back to sign in page
@sutterj sutterj requested a review from a team as a code owner June 12, 2024 17:04
@jmeridth
Copy link
Contributor

screenshot?

@sutterj
Copy link
Contributor Author

sutterj commented Jun 12, 2024

I took one before I opened the PR and then forgot to add it 🤦

jmeridth
jmeridth approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sutterj sutterj merged commit 86c6348 into main Jun 12, 2024
13 checks passed
@sutterj sutterj deleted the sutterj/unauth-button branch June 12, 2024 17:39
@sutterj sutterj added the enhancement New feature or request label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajhenry ajhenry ajhenry approved these changes

@jmeridth jmeridth jmeridth approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign-out button on the unauthorized page
3 participants
@sutterj @jmeridth @ajhenry