Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stricter eslint rules for typescript #163

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

ajhenry
Copy link
Contributor

@ajhenry ajhenry commented Jun 11, 2024

Pull Request

Proposed Changes

While we were pairing on #162, we found that we didn't add an await keyword to the function running the auth check. To prevent this from happening in the future, I added stricter eslint rules for typescript

This also fixes all the problems that arise from the addition of these rules. In general, we're looking pretty good 🥨

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run npm run lint and fix any linting issues that have been introduced
  • run npm run test and run tests
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

@ajhenry ajhenry requested a review from a team as a code owner June 11, 2024 21:03
@ajhenry ajhenry added the enhancement New feature or request label Jun 11, 2024
Copy link
Contributor

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


My only question on this one was whether this just ran locally or was enforced by a linting workflow but I found the npm lint job in the status checks so looks good! 👍🏻

@ajhenry
Copy link
Contributor Author

ajhenry commented Jun 11, 2024

@zkoppert luckily next comes with eslint support 😄

@ajhenry ajhenry merged commit 201749e into main Jun 11, 2024
15 checks passed
@ajhenry ajhenry deleted the ajhenry/eslint-rules branch June 11, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants