feat: add stricter eslint rules for typescript #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
While we were pairing on #162, we found that we didn't add an
await
keyword to the function running the auth check. To prevent this from happening in the future, I added stricter eslint rules for typescriptThis also fixes all the problems that arise from the addition of these rules. In general, we're looking pretty good 🥨
Readiness Checklist
Author/Contributor
npm run lint
and fix any linting issues that have been introducednpm run test
and run tests@jeffrey-luszcz
Reviewer
bug
,documentation
,enhancement
,infrastructure
,maintenance
, orbreaking