Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching estimates on checkout page #2022

Merged
merged 33 commits into from
Oct 23, 2023

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Jul 6, 2023

needs indexer work to return matching for multiple projects in a round, instead of downloading all the votes and calculating on client.

fixes #1994

@vacekj vacekj linked an issue Jul 6, 2023 that may be closed by this pull request
@vacekj vacekj force-pushed the 1931-spike-matching-estimates-for-donations branch from 75eadc4 to 4a554f6 Compare July 24, 2023 11:12
@vacekj vacekj closed this Sep 29, 2023
@vacekj vacekj force-pushed the 1931-spike-matching-estimates-for-donations branch from 0e42097 to 3d0e8f7 Compare September 29, 2023 10:37
@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:18am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:18am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:18am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:18am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:18am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:18am

@vacekj vacekj changed the title feat: matching estimate prototype Matching estimates on checkout page Sep 29, 2023
@vacekj vacekj reopened this Sep 29, 2023
@michellema1208
Copy link
Contributor

michellema1208 commented Oct 19, 2023

@boudra quick update from testing different wallets with different Passport scores:

Wallets:

  • Wallet with score 21.83: 0xB8c19A8bd5F308aA8Fe2997A6941820B34bAb9Ed
  • Wallet with score 2.45: 0x37e5e6eb36467F98392ebBb35F110FbB8238e6D3
  1. I'm not sure that I'm seeing the Passport sliding scale updates -- here's a Loom of my matching estimates with a wallet with a 2.45 Passport score -- I would expect to see $0 matching as my Passport score is not above 15.

Loom: https://www.loom.com/share/2574360101d74bbcb176aef90b186fa8

  1. From this Discord message, we were thinking of updating the color schema to match the Passport sliding scale updates.

Passport sliding scale threshold: For scores 15-25, give a 0-100% match (where 15 = 0% match and 25 = 100% match)

Use Cases - Colors:

  • No Passport Score detected - Red, potential estimate at 100% match
  • Score of 0: Gray, current estimate at 0% match
  • Score of 0-15: Orange, current estimate at 0% match
  • Score of 15-25: Yellow, current estimate at sliding scale match (% depends on the score you have, where 15 = 0% match and 25 = 100% match)
  • Score of 25+: Green, current estimate at 100% match

I think you got looped into Matching Estimates after this message was sent, so you may have missed it!

Let me know if you have any questions!

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 19, 2023

This PR is 89.64677222898904% new code.

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 19, 2023

🥷 Code experts: bhargavaparoksham

bhargavaparoksham, vacekj have most 👩‍💻 activity in the files.
vacekj, bhargavaparoksham have most 🧠 knowledge in the files.

See details

.github/workflows/grant-explorer.yml

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 12 additions & 9 deletions
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
vacekj: 44%

package.json

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 10 additions & 6 deletions
AUG
JUL 2 additions & 2 deletions
JUN 5 additions & 13 deletions
MAY

Knowledge based on git-blame:
vacekj: 53%

packages/common/package.json

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP
AUG
JUL 5 additions & 4 deletions
JUN
MAY 2 additions & 2 deletions

Knowledge based on git-blame:
vacekj: 88%
bhargavaparoksham: 6%

packages/common/src/chains.ts

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 6 additions & 0 deletions
AUG
JUL 46 additions & 0 deletions 65 additions & 46 deletions
JUN
MAY

Knowledge based on git-blame:
vacekj: 99%
bhargavaparoksham: 1%

packages/grant-explorer/src/features/api/types.ts

Activity based on git-commit:

bhargavaparoksham vacekj
OCT 17 additions & 3 deletions
SEP 1 additions & 1 deletions
AUG 12 additions & 39 deletions
JUL 1 additions & 1 deletions 2 additions & 1 deletions
JUN
MAY 2 additions & 1 deletions 9 additions & 1 deletions

Knowledge based on git-blame:
bhargavaparoksham: 28%
vacekj: 4%

packages/grant-explorer/src/features/contributors/__tests__/ViewContributionHistory.test.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 6 additions & 4 deletions
AUG 36 additions & 22 deletions
JUL 2 additions & 2 deletions
JUN 203 additions & 28 deletions
MAY

Knowledge based on git-blame:
bhargavaparoksham: 79%
vacekj: 21%

packages/grant-explorer/src/features/round/ViewCartPage/ProjectInCart.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 2 additions & 2 deletions
AUG 129 additions & 2 deletions
JUL
JUN
MAY

Knowledge based on git-blame:
bhargavaparoksham: 98%
vacekj: 2%

packages/grant-explorer/src/features/round/ViewCartPage/RoundInCart.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 2 additions & 2 deletions
AUG 52 additions & 0 deletions
JUL
JUN
MAY

Knowledge based on git-blame:
bhargavaparoksham: 96%
vacekj: 4%

packages/grant-explorer/src/features/round/ViewCartPage/SummaryContainer.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 13 additions & 7 deletions
AUG 368 additions & 0 deletions 11 additions & 16 deletions
JUL
JUN
MAY

Knowledge based on git-blame:
bhargavaparoksham: 94%
vacekj: 6%

pnpm-lock.yaml

Activity based on git-commit:

bhargavaparoksham vacekj
OCT
SEP 5514 additions & 9303 deletions
AUG 1158 additions & 202 deletions 7291 additions & 5024 deletions
JUL 1820 additions & 511 deletions
JUN 113 additions & 2139 deletions 278 additions & 2225 deletions
MAY 13 additions & 12 deletions

Knowledge based on git-blame:
vacekj: 68%
bhargavaparoksham: 2%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer: add matching estimates to checkout on cart page spike: Matching Estimates for Donations
4 participants