-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: complete svelte-5 migration #5395
Open
ndom91
wants to merge
13
commits into
master
Choose a base branch
from
migrate-svelte-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndom91
force-pushed
the
migrate-svelte-5
branch
from
November 1, 2024 15:38
a8ffa36
to
2f8f8ec
Compare
mtsgrd
reviewed
Nov 1, 2024
mtsgrd
reviewed
Nov 1, 2024
mtsgrd
reviewed
Nov 1, 2024
apps/desktop/src/lib/components/AIPromptEdit/DialogBubble.svelte
Outdated
Show resolved
Hide resolved
ndom91
force-pushed
the
migrate-svelte-5
branch
from
November 1, 2024 16:36
2157fff
to
77af6e5
Compare
ndom91
force-pushed
the
migrate-svelte-5
branch
from
November 1, 2024 16:44
77af6e5
to
5f55e5a
Compare
ndom91
force-pushed
the
migrate-svelte-5
branch
from
November 1, 2024 16:44
5f55e5a
to
e537170
Compare
Discard changes to apps/desktop/src/lib/branch/StackingSeriesDescription.svelte Discard changes to apps/desktop/src/lib/branch/StackingSeriesHeader.svelte Discard changes to apps/desktop/src/lib/commit/StackingCommitCard.svelte Discard changes to apps/desktop/src/lib/commit/StackingUpstreamCommitsAccordion.svelte Discard changes to apps/desktop/src/lib/components/AIPromptEdit/DialogBubble.svelte Discard changes to apps/desktop/src/lib/components/InsertEmptyCommitAction.svelte Discard changes to apps/desktop/src/lib/components/contextmenu/ContextMenuItem.svelte Discard changes to apps/desktop/src/lib/dropzone/LineOverlay.svelte Discard changes to apps/desktop/src/lib/navigation/DomainButton.svelte Discard changes to apps/desktop/src/lib/select/OptionsGroup.svelte fix: revert more :global css
ndom91
force-pushed
the
migrate-svelte-5
branch
from
November 1, 2024 17:00
96c9440
to
100451c
Compare
ndom91
force-pushed
the
migrate-svelte-5
branch
from
November 1, 2024 17:50
829a2fe
to
537c035
Compare
Realistically, we should land this after we have released the tauri v2 changes |
Yeah no rush, whenever makes the most sense 👍 Having tauri v2 released in a GA release for a bit first sounds reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
pnpm dlx sv migrate svelte-5
)pnpm-workspace.yml
package.json
Migration Guide: https://svelte.dev/docs/svelte/v5-migration-guide
🧢 Changes