-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #2594
Comments
Really looking forward trying this out on my win machine! Any chance this would run on WSL in the meantime? |
@francois-joubert It seems to run on my WSL instance but has DPI scaling issues that makes it unusable: |
@anaisbetts What kind of monitor do you have? On my Dell XPS 17 monitor it looks fine. The only problem is that the login does not work, I don't know if that has to do with it running in WSL. |
I installed firefox on my wsl instance and set it as my default browser using microsoft RDP to get into the settings app for the wsl instance (basic instructions for connecting via rdp here). Once I had a working default browser setup, I was able to complete the sign in process and have all features working via wsl. |
@Cerabbite This is on my laptop screen @ 200% scaling |
I have created a gist that provides a complete walkthrough for getting GitButler working on WSL: https://gist.github.com/KroniK907/24c6edafa2b34af773dc9466dd7e4e00 I have reduced the steps as much as possible, and provided instructions for installing both the AppImage version as well as the .deb version. The deb version takes 4 terminal commands and less than 2 minutes to get running, and while the AppImage version requires a little bit more effort to set up, allows for the app to update itself, rather than requiring a manual .deb install for each new release. Important note: this solution is really only practical if you are willing to set up your dev environment in WSL. Trying to make the WSL gitbutler instance interact with a project stored on the windows filesystem can be laggy or not work at all if it's a big enough project. |
@KroniK907 Thank you, this was way faster than my way which was compiling it from scratch. Though it is still very unstable for me.
Edit: After restarting git-butler a couple of time it worked fine |
Looking forward to Windows support! 🥳 |
Another windows user praying for win support, Unreal Engine dev not a great experience on linux, WSL is abit much effort as well |
@GIRU-GIRU I got GitButler setup on WSL in a matter of minutes. (I did already have WSL setup) I used this guide by @KroniK907
|
Looks like according to a comment on my gist that the WSL solution is really only viable if you are hosting your repos in WSL, otherwise the lag of having WSL access the windows file system makes it rather laggy and hard to use at best, and completely times out and is not useable at worst. However, if you are able to use WSL as your dev environment it works really nicely. |
Updated my gist to add instructions for installing GitButler as an AppImage. The main reason for adding the AppImage install instructions was because the AppImage version can update itself, while the .deb has to be manually updated for each release. Because the team is adding improvements and releasing new updates quickly, it seemed practical to provide install instructions for a version that did not require as much effort to keep up to date. |
I have and use WSL but my repos are windows only (WPF) looking forward for windows support |
Can't wait to test out the windows version 🤞 |
+1 for Windows build |
I have a setup where GUI apps from WSL run via VcXSrv on Windows side, one issue I encountered: The window appears, but it is empty,
These changes helped me solve the issue: |
When Windows is supported, will it have support for the WSL filesystem? I feel like installing gitbutler in WSL isn't the best solution for WSL devs. |
As a wsl dev, installing GitButler in WSL has been working great for me. But to your question about file access, any windows app can access the |
I also really want windows support, cannot wait! :) |
Would love to help get this running natively on Windows, what's currently blocking this? Native Windows dev so happy to help here! |
GitoxideLabs/gitoxide#1287 mentions this issue and has a few things to attack |
Which says about Windows support:
Which sounds to me like the thing to pick up here is getting a beta (alpha?) Windows build done, and letting people test it? Then we can find said "rough edges", make tickets for them and get them fixed. And a second mention about Windows support:
Git for Windows comes with the option to install ssh (if I recall correctly) and modern Windows versions might even support it out of the box. At least, my Windows dev box runs all git commands over ssh and also uses it for signing commits. A simple check to see if |
Modern Windows installations will have ssh installed and available as an .exe and I think a link library too. The git for windows depends on the install, for example I only install Git itself without any of the extras (I don't want their weird bundled terminal emulator and linuxy libraries, I just want git.exe - so I opt for installing only that, which may omit the ssh installs too since I never use ssh anyway) so a check to see if it's in Path like on any other system would make the most sense along with a helpful error message if not, linking to the relevant install docs. Is there any way SSH could just be packaged with the install in future, either via static linking or a DLL? |
One of the nice features of using SSH is the option for key based authentication and using Anyway, the "no native ssh transport yet" seems clear enough and solvable (take PS. According to some Microsoft blogs, SSH is available as a Windows Feature for general public from Windows 10 version 1803 (released early 2018) onwards. |
That's right! It's trivial to install or check if it's available and installed with DISM or its equivalent Powershell commands, it's as simple as But wait, there's more! Microsoft is working on an updated version on GitHub, and ship beta versions which can be installed with winget (literally just Hope that helps! |
Ok, tested out recent changes awesome job so far! Currently i can interact with GitButler with mostly no issues. Things that are working now:
What is still broken:
Once again awesome work, will update post if i find anything else. |
Glad to hear it. Tests failing are also down from ~170 or so to just 37. I'm going through and revising how we handle paths but it'll take a bit of work - however I believe that's the source of most of the remaining failures.
Yeah the push/pull stuff is going to be a pain to fix, libgit2 famously doesn't do push/pull on Windows very well. I haven't even begun investigating that yet but will get to it at some point. For now, you can do pushes manually via the CLI. All of our refs are stored under Keep in mind this isn't officially supported and might change in the future (but might not). But for now, that should suffice as a workaround.
This should be easy enough to fix; I believe @mtsgrd mentioned he might just do this from the frontend if possible instead of proxying through Tauri. We still need to investigate this one, as we've had issues with this even on other platforms in the past.
Very strange. Can you run I'll make a note of this to check over the next few days. Thanks for the heads up :)
Indeed, this is because you're under Dev mode. Barring other windows-related issues, this should fix itself once we cut official builds. At some point we'll probably try to get this working under dev mode but that's low priority for us at the moment. Thanks again for all the feedback, keep it coming if you find any more :) |
#3262 just landed, adding fetch/push support for Windows via the "System Executable" auth method, settable via the project settings. Make sure to have Please let me know how it goes :) |
Been trying out a Windows build of GitBulter (from commit ce548ac) only issue I've really noticed is that the login refuses to work for me it's hitting a CORS error but interestingly only in nightly/release build not when running Great to see the Windows support actively being worked on! |
Hey @DrBarnabus can you try again? We just updated our CORS policy to hopefully fix that. Shouldn't need to reinstall, perhaps just restart the app for good measure. Let me know :) EDIT: Just heard back, it'll be about 30 minutes before it's live. Try again in about 30-45 minutes :) |
A few updates:
We're pretty close to having windows releases :) We're in the process of receiving certificates to allow us (hopefully, if the Microsoft gods allow us) to not have the "Windows just protected your computer" dialogs pop up when you run the installer after downloading it. Once that's set up, we'll probably go ahead with an official release. Thanks for bearing with us! |
Just retested and that's now working which is great. Saw nightly builds are available now I'll keep up to date and report any other issues! |
That's great news! Apologies for asking the (probably_ obvious, but where can the nightlies be found? |
This comment was marked as resolved.
This comment was marked as resolved.
You can find the nightlies on our downloads page! https://app.gitbutler.com/downloads |
Testing out the nightly, i can only move a single file to a virtual branch when i try to move a second i get the error |
Thanks! I see that got a lot of attention and the first issues reported in this thread already. Shall we follow the Bugs and Feature Requests section of the main readme and make separate issue reports, or do you prefer issues dumped in this thread for now? |
Once we get the certs for publishing a non-nightly build and we can verify it's working with the folks here, I'll go ahead and close this issue and we can start with normal bug reports :) Still want to make sure we've not missed anything major, especially with the code signing, as it could cause people to have Windows Defender freak out if not done correctly. |
Hey @slingshotvfx, I'm not sure of a workaround for this. This is, unfortunately, a huge limitation of the Windows network drives (perhaps just the WSL drive, perhaps not - perhaps even just WSL1, as that's all I use) that affects a lot of software. For example, Cargo won't even work for me if I Unless there's a trick that solves this somehow, it's not something I think we can work around :/ We should definitely document this, though - I think it should be trivial enough to determine if it's a network drive on Windows and show a warning/error. |
@Qix- just to clarify, this was running the windows nightly and trying to access a repo on a windows drive (Z:\ in my case) that is mapped to an smb network share. No WSL or cross-platform access shenanigans. Adding a project from a UNC path (e.g. \\server\path\to\repo) also gives me the same error. |
Ah sorry, yeah I misread. It must just be a network share thing, unfortunately. I'll have to look a bit more into this to see if there's some sort of workaround, but I can't make any promises it'll happen soon. |
I did have the same problem. I could fix it by installing the latest version of git. I did |
Unfortunately I still receive the same error with the latest version of git for windows. |
This comment was marked as spam.
This comment was marked as spam.
Unsure if it's isolated just to windows, I'd imagine it is though as I couldn't see any similar reports in issues, but I ran into an error updating the base branch yesterday. Raised #3412 |
Found two things on "Windows Nightly 0.5.400" I'm not sure, if it should say OpenAI API, if I select Anthropic? Is that right? And one small, unimportant thing: Moved to #3474 |
Hey @2Friendly4You, that's probably not windows-specific. Mind searching for/opening a new issue for that? Would be appreciated :) |
Hi all, we just launched signed Windows builds - check out https://gitbutler.com for them (direct link to MSI). Going to close this issue now; if there are any outstanding issues you're facing, please open them as new issues and let us know you're running under Windows so we can properly track them. Keep in mind we're still in beta, so keep the bug reports flowing so we can address them and make things a bit less beta 🙃 Finally, Thank you to everyone who provided feedback ❤️- GitButler Team |
Tracking windows support
Hello everyone, Windows support is live. See #2594 (comment) and https://gitbutler.com for links!
The text was updated successfully, but these errors were encountered: