Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jest to v29 #959

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Upgrade Jest to v29 #959

merged 1 commit into from
Sep 12, 2024

Conversation

dennisameling
Copy link
Contributor

Jest 29 was released in August of 2022 already, so not sure why this wasn't detected by Dependabot earlier. Running an npm outdated locally showed that we were using an older version of Jest.

@dscho
Copy link
Member

dscho commented Sep 12, 2024

not sure why this wasn't detected by Dependabot earlier.

I think the reason is the ^ in front of the version number, which according to the package.json documentation means that we need any updates to be "compatible with" this version. According to SemVer, incrementing the major version number is done when the version becomes incompatible.

@dscho dscho merged commit e1e17e3 into main Sep 12, 2024
2 checks passed
@dscho dscho deleted the jest-v29 branch September 12, 2024 10:38
@dennisameling
Copy link
Contributor Author

I think the reason is the ^ in front of the version number, which according to the package.json documentation means that we need any updates to be "compatible with" this version. According to SemVer, incrementing the major version number is done when the version becomes incompatible.

That ^ only applies when running npm update, so it stays within the bounds of the same major version. However, I expected Dependabot to flag this major upgrade in a PR. It also opened a PR to upgrade @typescript-eslint/eslint-plugin from 7.18.0 to 8.4.0, which had the same ^ syntax in the package.json file 🤷🏼‍♂️

Anyway, thanks for the quick review and the merge!

@dscho
Copy link
Member

dscho commented Sep 12, 2024

Huh, you're right... strange!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants