Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset READONLY if rename fails #4527

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Reset READONLY if rename fails #4527

merged 1 commit into from
Aug 7, 2023

Conversation

dsl101
Copy link

@dsl101 dsl101 commented Jul 28, 2023

OK, having another go at making a clean PR for this.

@dsl101 dsl101 force-pushed the fix-rename-readonly branch from efce07d to 1c73ec0 Compare July 28, 2023 14:28
@dsl101 @dscho
mingw: work around rename() failing on a read-only file
04a3d4e 
At least on _some_ APFS network shares, Git fails to rename the object
files because they are marked as read-only, because that has the effect
of setting the uchg flag on APFS, which then means the file can't be
renamed or deleted.

To work around that, when a rename failed, and the read-only flag is
set, try to turn it off and on again.

This fixes git-for-windows#4482

Signed-off-by: David Lomas <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the fix-rename-readonly branch from 1c73ec0 to 04a3d4e Compare August 7, 2023 13:44
@dscho dscho added this to the Next release milestone Aug 7, 2023
@dscho dscho merged commit 7d048b1 into git-for-windows:main Aug 7, 2023
@dscho
Copy link
Member

dscho commented Aug 7, 2023 •
edited by gitforwindowshelper bot
Loading

/add relnote bug When running on a remote APFS share, Git would fail, which has been fixed.

The workflow run was started

github-actions bot pushed a commit to git-for-windows/build-extra that referenced this pull request Aug 7, 2023
Add a release note (bug)
d217c6c 
When running on a remote APFS share, Git [would
fail](git-for-windows/git#4482), which [has
been fixed](git-for-windows/git#4527).

Signed-off-by: gitforwindowshelper[bot] <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
2c7ca15 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
b1dd69a 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
4b5f769 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
116def8 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
2042ef3 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
9bbf3d7 
OK, having another go at making a clean PR for this.
dscho added a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
38e688b 
OK, having another go at making a clean PR for this.
dscho added a commit to dscho/git that referenced this pull request Aug 7, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
6f3707d 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
3512145 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
9fffddc 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 7, 2023
@dscho
Reset READONLY if rename fails (#4527)
b5dcd8a 
OK, having another go at making a clean PR for this.
git-for-windows-ci pushed a commit that referenced this pull request Aug 8, 2023
@dscho
Reset READONLY if rename fails (#4527)
ded1947 
OK, having another go at making a clean PR for this.
dscho added a commit to dscho/git that referenced this pull request Aug 8, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
09dd4ea 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 8, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
6c4399f 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 8, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
901e78e 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
7a8ba6f 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
1641a82 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
2ff8c8d 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
c9f3ee8 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
613deed 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
d8f9dc6 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 9, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
f8ec49f 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Aug 10, 2023
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
9d971fd 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Dec 30, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
7ff6910 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Dec 30, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
2bcb465 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Dec 30, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
5815e64 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Dec 30, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
dc14681 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Dec 30, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
46128ee 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Dec 30, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
607d7a2 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Dec 31, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
8e5c4f6 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Dec 31, 2024
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
1d14f26 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 1, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
bfb1380 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 1, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
35a5356 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 1, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
8ea9f87 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 1, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
eb75725 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 1, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
74076d8 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 2, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
ca653b8 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 2, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
81d908f 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 2, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
0a4c79b 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 3, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
a0c00a2 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 6, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
9102265 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 6, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
afdfffc 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
a1f8db8 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
628f92e 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this pull request Jan 7, 2025
Open
dscho added a commit to dscho/git that referenced this pull request Jan 7, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
1ebeed2 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/git that referenced this pull request Jan 7, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (git-for-windo…
1449d86 
…ws#4527)

With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
1b68ba7 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
9066084 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
127ee5f 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
180aab7 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
a766dc4 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
mingw: try resetting the read-only bit if rename fails (#4527)
5b7e70e 
With this patch, Git for Windows works as intended on mounted APFS
volumes (where renaming read-only files would fail).

Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dsl101 @dscho