Reset read-only attributes during rename operation #4483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2023 12:23
|
OK, sorry, didn't mean to include v1 in there (failing whitespace check). I will close this one and reopen a new one. |
For the record, you can easily force-push and re-use the same PR. That's actually my preference, to keep things together that belong together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, this is an edge case as discussed here. Running git on windows for a repo that is mounted on an APFS filesystem fails, as it's not possible to rename a 'locked' (read only) file on APFS. This workaround checks if the rename fails, and if
FILE_ATTRIBUTE_READONLYis set, resets it before attempting the rename again. If that succeeds,FILE_ATTRIBUTE_READONLYis applied to the renamed file.