Let the documentation reflect that there is no vs/master anymore

[dscho]

While rebasing Git for Windows onto v2.32.0-rc0, I noticed that the documentation was stale: vs/master (or more appropriately, vs/main) is no longer updated, and was deprecated in favor of using CMake already a long time ago.

[PhilipOakley]

While I fully support the changes, my recent experience is that the VS2019 integration isn't working properly when started from a clean slate.

If I understand correctly, the cause is that VS2019 has changed it's default generator to 'Ninja' and doesn't therefore set the MSVC property needed for the CMake initialisation. Also the default ARCH setting isn't being picked up in the cmake code when it's set in the install_vcpkg.bat. It can be tricky to test as it's awkward to ensure a truly clean setup of a fresh VS2019 etc.

[dscho]

That may be so, but we should fix the experience, then. I could imagine that the recent ARM64 work might have broken the Ninja-based build process, but the good news is that we're unlikely to change this part of the code base anytime soon (except to fix the bug you reported). Would you mind walking through the process from scratch and opening a new ticket with the findings?

[PhilipOakley]

Would you mind walking through the process from scratch and opening a new ticket with the findings?

I hope to do that. Time has been a bit limited of late. I had been making some notes in #3176 and have some local notes trying to get to the bottom of the issue (lots of StackOverflow links ;-)

My aim is that the code should work straight out of the tin to encourage those who want to investigate the code who don't yet feel able to make the leap to being 'contributors' (which links to also wanting to get Sourcetrail to integrate a little more easily.)