git-artifacts: Update ARM64 GCM Core workaround #3085
Conversation
| if: matrix.arch.arm64 == true | ||
| shell: bash | ||
| run: | | ||
| printf '%s\n' '#!/bin/sh' 'exec /mingw32/libexec/git-core/git-credential-manager-core.exe "$@"' > arm64/bin/git-credential-manager-core |
There was a problem hiding this comment.
I bet it works if it's put into arm64/libexec/git-core/ instead of arm64/bin/.
And honestly, I'd prefer that over the build-extra PR, to minimize the impact outside git-artifacts...
There was a problem hiding this comment.
@dscho that works, thanks! Just updated the commit accordingly.
I was curious as to what libexec does exactly, and found this definition:
libexec is meant for system daemons and system utilities executed by other programs. That is, the binaries put in this namespaced directory are meant for the consumption of other programs, and are not intended to be executed directly by users.
Learning every day 🚀
dennisameling
force-pushed
the
remove-gcm-core-workaround
branch
from
4842189
to
c74e2c4
Compare
dennisameling
changed the title
|
Very nice! Now, the most important question: does it still fix the issue in your tests? 😉 |
dennisameling
force-pushed
the
remove-gcm-core-workaround
branch
from
c74e2c4
to
5174918
Compare
|
Just did a fresh installation based on the artifacts in https://github.com/dennisameling/git/actions/runs/632238966 (also deleted ~/.gitconfig), and it works! 🚀 Before: After: |
It turned out that our workaround doesn't work if the git-credential-manager-core wrapper is put into the /arm64/bin folder, but is does work when putting it into the /arm64/libexec folder. This PR moves the git-credential-manager-core wrapper to /arm64/libexec. Signed-off-by: Dennis Ameling <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
remove-gcm-core-workaround
branch
from
5174918
to
efa8abe
Compare
We have moved and improved this logic to
build-extrain git-for-windows/build-extra#331. More details in that PR.