git-artifacts: add ARM64 artifacts #3017

dennisameling · 2021-02-04T17:26:33Z

Adds the ARM64 artifacts to the git-artifacts GH Actions workflow 🚀

Full run: https://github.com/dennisameling/git/actions/runs/537829979

One thing I noticed is that the ARM64 artifacts are significantly larger than the others. There might be some things we can enable on the MSVC-size to have it generate smaller binaries, but I'm not familiar enough with that toolchain to know how to do that.

.github/workflows/git-artifacts.yml

dscho

I left a couple suggestions how we could potentially fix this, but I think we first need that build-extra PR.

.github/workflows/git-artifacts.yml

dennisameling · 2021-02-06T22:24:40Z

@dscho applied your suggestions - hope we're good to go now! 😊

Successful run: https://github.com/dennisameling/git/actions/runs/543959657
Demo release (manual): https://github.com/dennisameling/git/releases/tag/2.30.0-beta3

dennisameling · 2021-02-07T12:19:59Z

@dscho fixed - build-arm64 is now also using git-sdk-64-build-installers. Last time I checked, I forgot to set MSGFMT_EXE to the correct folder 😅

-DMSGFMT_EXE=`pwd`/git-sdk-64-build-installers/mingw64/bin/msgfmt.exe

dscho · 2021-02-07T13:53:28Z

Hmm. If we built with NO_GETTEXT (or the CMake equivalent), we would not even need msgfmt.exe. Meaning: we could totally save us the trouble to download any version of the Git for Windows SDK.

dennisameling · 2021-02-07T14:48:15Z

Like this? Looks like that works as well: https://github.com/dennisameling/git/runs/1849261988?check_suite_focus=true

Don't we need to do this in the other, already existing workflow then (vs-build)?

dscho · 2021-02-08T22:19:05Z

Like this?

Yes, please!

Don't we need to do this in the other, already existing workflow then (vs-build)?

Very good point! We even need it in git/git, not only in git-for-windows/git.

dennisameling · 2021-02-09T08:53:23Z

Alright, just squashed the commits. Think we're good to go here, @dscho!

Actions run: https://github.com/dennisameling/git/actions/runs/550766092

Very good point! We even need it in git/git, not only in git-for-windows/git.

Will do this later today 👍🏼

dennisameling · 2021-02-11T14:33:42Z

Will do this later today 👍🏼

Done in #3040, sorry for the delay!

dscho · 2021-02-11T15:34:51Z

.github/workflows/git-artifacts.yml

@@ -388,7 +448,8 @@ jobs:
        run: |
          & .\git-sdk-${{matrix.arch.bitness}}-build-installers\usr\bin\bash.exe -lc @"
            set -x
-            /usr/src/build-extra/please.sh make_installers_from_mingw_w64_git --version=`$(cat pkg-${{matrix.arch.name}}/ver) -o artifacts --${{matrix.artifact.name}} --pkg=pkg-${{matrix.arch.name}}/mingw-w64-${{matrix.arch.name}}-git-[0-9]*.tar.xz --pkg=pkg-${{matrix.arch.name}}/mingw-w64-${{matrix.arch.name}}-git-doc-html-[0-9]*.tar.xz &&
+            [[ \"${{matrix.arch.arm64}}\" = true ]] && ARM64=\"--include-arm64-artifacts=\"`$PWD/arm64\"\" || ARM64=


I think those quotes should not be escaped, right?

Oh, forget what I said, this is inside a PowerShell step. But that means that there needs to be extra quoting around the path, like so:

Suggested change

[[ \"${{matrix.arch.arm64}}\" = true ]] && ARM64=\"--include-arm64-artifacts=\"`$PWD/arm64\"\" || ARM64=

[[ \"${{matrix.arch.arm64}}\" = true ]] && ARM64=\"--include-arm64-artifacts=\\\"`$PWD/arm64\\\"\" || ARM64=

Interesting. It worked without the quotes, but with the quotes it breaks the installer build: https://github.com/dennisameling/git/runs/1881018607?check_suite_focus=true

Looks like we need to tweak the release.sh script in build-extra/installer a bit. Will have a look tomorrow.

dscho

It looks really neat now, just the one quoting fix (which does not matter that much in practice right now because $PWD expands to a path without spaces).

Adds ARM64 artifacts to the git-artifacts GitHub Action workflow. Signed-off-by: Dennis Ameling <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>

git-artifacts: add ARM64 artifacts

…artifacts git-artifacts: add ARM64 artifacts

git-artifacts: add ARM64 artifacts

dennisameling commented Feb 4, 2021

View reviewed changes

.github/workflows/git-artifacts.yml Outdated Show resolved Hide resolved

dennisameling force-pushed the add-arm64-artifacts branch 3 times, most recently from 1fffb92 to 6bb1f51 Compare February 4, 2021 21:12

dscho requested changes Feb 4, 2021

View reviewed changes

dennisameling force-pushed the add-arm64-artifacts branch 3 times, most recently from 5da7f80 to 0f8e66c Compare February 6, 2021 21:52

dennisameling requested a review from dscho February 6, 2021 22:24

dennisameling force-pushed the add-arm64-artifacts branch from 0f8e66c to 98fdd1e Compare February 7, 2021 12:01

dennisameling force-pushed the add-arm64-artifacts branch from d1b7162 to 7e41cc8 Compare February 9, 2021 08:51

dennisameling mentioned this pull request Feb 11, 2021

.github: build vs-build with NO_GETTEXT #3040

Merged

dscho reviewed Feb 11, 2021

View reviewed changes

git-artifacts: add ARM64 artifacts

ab950ae

Adds ARM64 artifacts to the git-artifacts GitHub Action workflow. Signed-off-by: Dennis Ameling <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>

dscho force-pushed the add-arm64-artifacts branch from d013398 to ab950ae Compare February 12, 2021 13:15

dscho approved these changes Feb 13, 2021

View reviewed changes

dscho merged commit a1dbd69 into git-for-windows:main Feb 13, 2021

dennisameling deleted the add-arm64-artifacts branch February 14, 2021 14:20

dscho added a commit that referenced this pull request Feb 15, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

5096296

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Feb 15, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

09b43a7

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Feb 15, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

f48faee

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Feb 15, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

e31a706

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 2, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

1fe082a

git-artifacts: add ARM64 artifacts

dscho added a commit to dscho/git that referenced this pull request Aug 3, 2021

Merge pull request git-for-windows#3017 from dennisameling/add-arm64-…

b9cd00a

…artifacts git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

086e903

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 3, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

dc06d3d

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 3, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

9044a4e

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 3, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

923e7f8

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

e3d26d1

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

0fedbda

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

1d098b8

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

960d317

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

8344fc1

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

98881cc

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 6, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

9537921

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 6, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

a55600c

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 6, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

ea5ea6a

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 11, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

a9173cf

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 13, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

54c87ad

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 18, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

bc104e8

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 23, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

1add165

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Aug 24, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

e4bff23

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Aug 31, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

a7b7d35

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Sep 8, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

a78b2ea

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Sep 13, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

10f08c4

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Oct 4, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

84f7f3b

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Oct 12, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

9fb8b22

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Oct 12, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

921716f

git-artifacts: add ARM64 artifacts

dscho added a commit that referenced this pull request Oct 13, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

96414c2

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Oct 13, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

8629501

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Oct 13, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

2c8d096

git-artifacts: add ARM64 artifacts

git-for-windows-ci pushed a commit that referenced this pull request Oct 13, 2021

Merge pull request #3017 from dennisameling/add-arm64-artifacts

adc7592

git-artifacts: add ARM64 artifacts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

git-artifacts: add ARM64 artifacts #3017

git-artifacts: add ARM64 artifacts #3017

dennisameling commented Feb 4, 2021 •

edited

Loading

dscho left a comment

dennisameling commented Feb 6, 2021 •

edited

Loading

dennisameling commented Feb 7, 2021

dscho commented Feb 7, 2021

dennisameling commented Feb 7, 2021 •

edited

Loading

dscho commented Feb 8, 2021

dennisameling commented Feb 9, 2021

dennisameling commented Feb 11, 2021 •

edited

Loading

dscho Feb 11, 2021

dscho Feb 11, 2021

dennisameling Feb 11, 2021

dscho left a comment

	[[ \"${{matrix.arch.arm64}}\" = true ]] && ARM64=\"--include-arm64-artifacts=\"`$PWD/arm64\"\" \|\| ARM64=
	[[ \"${{matrix.arch.arm64}}\" = true ]] && ARM64=\"--include-arm64-artifacts=\\\"`$PWD/arm64\\\"\" \|\| ARM64=

git-artifacts: add ARM64 artifacts #3017

git-artifacts: add ARM64 artifacts #3017

Conversation

dennisameling commented Feb 4, 2021 • edited Loading

dscho left a comment

Choose a reason for hiding this comment

dennisameling commented Feb 6, 2021 • edited Loading

dennisameling commented Feb 7, 2021

dscho commented Feb 7, 2021

dennisameling commented Feb 7, 2021 • edited Loading

dscho commented Feb 8, 2021

dennisameling commented Feb 9, 2021

dennisameling commented Feb 11, 2021 • edited Loading

dscho Feb 11, 2021

Choose a reason for hiding this comment

dscho Feb 11, 2021

Choose a reason for hiding this comment

dennisameling Feb 11, 2021

Choose a reason for hiding this comment

dscho left a comment

Choose a reason for hiding this comment

dennisameling commented Feb 4, 2021 •

edited

Loading

dennisameling commented Feb 6, 2021 •

edited

Loading

dennisameling commented Feb 7, 2021 •

edited

Loading

dennisameling commented Feb 11, 2021 •

edited

Loading