POC: Simplify clean command's approach remove_dirs #1415
Conversation
Fixes 607 which only happens with Junction Points on Windows. The fix discussed in the issue was to first try the simple approach of deleting a directory with unlink before launching into recursing into its directory structure.
|
The "All checks have passed" message has me puzzled. Is appveyor running tests? Perhaps there's something wrong with the configuration of my dev machine, but I can't get the tests to run successfully. |
AppVeyor says: "The build job has not produced any test results." 😏 |
|
Yea, I guess that may be an indication that I may not be alone in having trouble getting the tests to run. |
That's because AppVeyor has a 20 minute timeout, and the VMs they use would probably spend something like 2 hours to run the entire test suite. |
| if (res == 0) { | ||
| printf(dry_run ? _(msg_would_remove) : _(msg_remove), path->buf); | ||
| ret = res; | ||
| goto out; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
For me, the current revision of this Pull Request passes on Windows, on Linux and on macOS. Could you provide details how it is failing for you? |
|
Sorry @dscho, I've been engaged on non-software matters, just getting back to this (on a new machine.) Its been so long I have forgotten what prerequisites to install to build, I don't even have a "make" command in my default CMD prompt. Can you recommend which make to use? (I'm now wondering if some sort of build tool mismatch might have lead to my previous problems.) I looked for a prerequisites list or some sort of build/test cycle docs specific to Windows, but didn't find one. Did I miss something obviously. |
|
Just download and install the Git for Windows SDK. It should make things easier now (we worked a bit on it in the meantime). |
|
Just to reiterate: I think that the plain I outlined earlier is our best bet to resolve this once and for all. Sadly, I really need to rely on contributors taking up the challenge, as I am too swamped with other projects (such as Google Summer of Code, mentoring essentially three students, getting range-diff upstream and GitGitGadget set up. Oh, and day job). |
|
Superseded by #1976. |
This is a proof of concept PR for discussion only, do not merge.
I'm not currently able to get tests to pass with this change.
Fixes #607 which only happens with Junction Points on Windows. The fix discussed in the issue was to first try the simple approach of deleting a directory with unlink before launching into recursing into its directory structure.