Implement pthread_cond_t with Win32 CONDITION_VARIABLE #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Win32 CONDITION_VARIABLE has better performance and is easier to maintain. Since CONDITION_VARIABLE is not available in Windows XP and below, old implementation of pthread_cond_t is kept under define guard 'GIT_WIN_XP_SUPPORT'. To enable old implementation, build with make CFLAGS="-DGIT_WIN_XP_SUPPORT". Signed-off-by: Loo Rong Jie <[email protected]> fast-forwarded.
Signed-off-by: Loo Rong Jie <[email protected]>
|
See also for bumping bumped |
|
@dscho Ping? |
whoisj
reviewed
Jul 7, 2017
compat/win32/pthread.c
Outdated
| @@ -57,6 +57,8 @@ pthread_t pthread_self(void) | |||
| return t; | |||
| } | |||
|
|
|||
| #ifdef GIT_WIN_XP_SUPPORT | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Loo Rong Jie <[email protected]>
|
Thank you so much! |
dscho
added a commit
that referenced
this pull request
Aug 15, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Aug 16, 2017
The XP-compatibility layer emulating pthreads (which is [no longer needed](https://git-for-windows.github.io/requirements.html) [was dropped in favor of modern Windows threading APIs](git-for-windows/git#1214); This should make threaded operations slightly faster and more robust. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Aug 18, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 18, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 20, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Aug 22, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 23, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 24, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 24, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 24, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 24, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 25, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 25, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Aug 26, 2017
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Mar 23, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Apr 3, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
May 29, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
May 29, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Aug 22, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 22, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Aug 28, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 5, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 10, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 11, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
that referenced
this pull request
Oct 10, 2018
Implement pthread_cond_t with Win32 CONDITION_VARIABLE
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 11, 2018
This was pull request git-for-windows#1214 from rongjiecomputer/master Implement pthread_cond_t with Win32 CONDITION_VARIABLE Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 19, 2018
This was pull request git-for-windows#1214 from rongjiecomputer/master Implement pthread_cond_t with Win32 CONDITION_VARIABLE Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Nov 21, 2018
This was pull request #1214 from rongjiecomputer/master Implement pthread_cond_t with Win32 CONDITION_VARIABLE Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Win32 CONDITION_VARIABLE has better performance and is easier to maintain.
Since CONDITION_VARIABLE is not available in Windows XP and below, old implementation of pthread_cond_t is kept under define guard 'GIT_WIN_XP_SUPPORT'. To enable old implementation, build with
make CFLAGS="-DGIT_WIN_XP_SUPPORT".If I build with
make CFLAGS="-D_WIN32_WINNT=0x0600or change the define in git-compat-util.h, I will get many warnings and errors about symbols incompat/poll/poll.hare redefined becausewinsock2.hdefine them already when_WIN32_WINNT=0x0600.I choose the simpler solution: keep the old _WIN32_WINNT and declare the 4 required Win32 functions in
pthread.c.