Fix processing of translated messages in git-artifacts
#4952
Comments
dscho
added a commit
to dscho/build-extra
that referenced
this issue
Jun 18, 2024
In msys2/MSYS2-packages@d7c37ffdadd, `gettext` was identified as an incorrect dependency of the `xz` package and that dependency was dropped. As a consequence, Git for Windows no longer included `gettext`, which uncovered a bug in the definition of the `build-installers` SDK artifact where it relied on that implicit dependency instead of making it an explicit requirement (needed by `makepkg` and `makepkg-mingw`). Let's make it explicit that `gettext.exe` (and `xgettext.exe`) are to be included in the `build-installers` SDK artifact. This fixes git-for-windows/git#4952. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to git-for-windows/git-sdk-64
that referenced
this issue
Jul 22, 2024
In msys2/MSYS2-packages@d7c37ffdadd, `gettext` was identified as an incorrect dependency of the `xz` package and that dependency was dropped. As a consequence, Git for Windows no longer included `gettext`, which uncovered a bug in the definition of the `makepkg-git` SDK artifact where it relied on that implicit dependency instead of making it an explicit requirement (because it is needed by `makepkg` and `makepkg-mingw`). Let's make it explicit that `gettext.exe` (and `xgettext.exe`) are to be included in the `makepkg-git` SDK artifact. While at it, also avoid the "`error_highlight' was not loaded." warning when building Git for Windows' `mingw-w64-git-doc-html` package. This addresses the previously-forgotten x86_64 part of git-for-windows/git#4952; The i686 part of was fixed by git-for-windows/build-extra#560 already. Signed-off-by: Johannes Schindelin <[email protected]>
|
Turns out that git-for-windows/build-extra#560 only addressed the i686 build, but not the x86_64 one. I fixed this via git-for-windows/git-sdk-64@a6f190c. |
dscho
added a commit
to git-for-windows/git-sdk-arm64
that referenced
this issue
Aug 13, 2024
In msys2/MSYS2-packages@d7c37ffdadd, `gettext` was identified as an incorrect dependency of the `xz` package and that dependency was dropped. As a consequence, Git for Windows no longer included `gettext`, which uncovered a bug in the definition of the `makepkg-git` SDK artifact where it relied on that implicit dependency instead of making it an explicit requirement (because it is needed by `makepkg` and `makepkg-mingw`). Let's make it explicit that `gettext.exe` (and `xgettext.exe`) are to be included in the `makepkg-git` SDK artifact. While at it, also avoid the "`error_highlight' was not loaded." warning when building Git for Windows' `mingw-w64-git-doc-html` package. This addresses the previously-forgotten x86_64 part of git-for-windows/git#4952; The i686 part of was fixed by git-for-windows/build-extra#560 already. Ported-from-git-sdk-64: a6f190c (makepkg-git: do include gettext and error_highlight, 2024-07-22) Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that recent
git-artifactsbuilds ingit-sdk-64started outputting lines like this:The reason is most likely that I recently changed Git for Windows not to include
gettext, and themakepkg-gitsparse-checkout definition needing to account for that.A probable consequence of this issue is that the translated messages (which are not shipped in Git for Windows' installer, to save on bandwidth) are either broken or not even included in the
mingw-w64-gitpackage anymore.The text was updated successfully, but these errors were encountered: