Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw-w64-asciidoctor: install to sdk #19

Closed
wants to merge 1 commit into from

Conversation

dennisameling
Copy link
Collaborator

In a recent change, GfW switched from the homegrown -asciidoctor-extensions package to the MSYS2-provided -asciidoctor one, as there's no need for the former nowadays.

The changes from #18 don't actually do much in this specific SDK, because unlike git-sdk-64 and git-sdk-32, -asciidoctor-extensions was never installed on git-sdk-arm64 in the first place.

This commit installs -asciidoctor and its dependencies:

mingw-w64-clang-aarch64-gdbm-1.19-3
mingw-w64-clang-aarch64-libyaml-0.2.5-2
mingw-w64-clang-aarch64-pdcurses-4.4.0-1
mingw-w64-clang-aarch64-ruby-3.1.5-1
mingw-w64-clang-aarch64-asciidoctor-2.0.23-1

Ref: git-for-windows/MINGW-packages@907ead4

In a recent changes, GfW switched from the homegrown
`-asciidoctor-extensions` package to the MSYS2-provided
`-asciidoctor` one, as there's no need for the former nowadays.

This commit installs `-asciidoctor` and its dependencies:

mingw-w64-clang-aarch64-gdbm-1.19-3
mingw-w64-clang-aarch64-libyaml-0.2.5-2
mingw-w64-clang-aarch64-pdcurses-4.4.0-1
mingw-w64-clang-aarch64-ruby-3.1.5-1
mingw-w64-clang-aarch64-asciidoctor-2.0.23-1

Ref: git-for-windows/MINGW-packages@907ead4
Signed-off-by: Dennis Ameling <[email protected]>
@dscho
Copy link
Member

dscho commented Jun 18, 2024

I'd prefer to have this as a patch to update-via-pacman.ps1, so that it is more obvious that a boring old workflow installed the packages, not a human being (which would have security implications).

So maybe you can change this conditional clause to trigger on the absence of var/lib/pacman/local/mingw-w64-*-asciidoctor-[0-9]* instead of the presence of the corresponding -asciidoctor-extensions folder?

That should have the same effect as this here PR, but easier to reason about how safe the change is.

@dennisameling
Copy link
Collaborator Author

Works for me! Will update the script in the next 1-2 days as I wrap up some other work.

@rimrul
Copy link
Member

rimrul commented Jun 18, 2024

So maybe you can change this conditional clause to trigger on the absence of var/lib/pacman/local/mingw-w64-*-asciidoctor-[0-9]* instead of the presence of the corresponding -asciidoctor-extensions folder?

Might make sense to split it into one part that removes mingw-w64-asciidoctor-extensions if installed and one part that installs mingw-w64-asciidoctor if missing.

@dennisameling
Copy link
Collaborator Author

dennisameling commented Jun 21, 2024

Closing this PR in favor of #20

@dennisameling dennisameling deleted the install-asciidoctor branch June 23, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants