Use signed version comparisons before recommending upgrade #358
Conversation
Currently, this is failing, but it documents what we want. Signed-off-by: Johannes Schindelin <[email protected]>
Swapping the arguments should yield the negative result. Signed-off-by: Johannes Schindelin <[email protected]>
…ifferently Instead of insisting on single period characters to separate the numbers (and ignoring everything after an unexpected character), let's just ignore the non-numeric parts altogether (with one special exception for `-rc` versions). This fixes our "unit" test. Signed-off-by: Johannes Schindelin <[email protected]>
Whenever we have unmatched versions, do a signed comparison. A user might have installed a prerelease version that is not yet a full release. This is particularly important in the microsoft/git world. Signed-off-by: Derrick Stolee <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
git-extra/git-update-git-for-windows
Outdated
| fi | ||
|
|
||
| return 0 | ||
| } |
There was a problem hiding this comment.
Hmm. I dislike the complexity of having to do lexicographic comparisons... Let me try whether I can come up with an alternative solution real quick.
There was a problem hiding this comment.
Sorry, I meant to comment immediately but forgot to "finalize my review".
|
@derrickstolee I think I came up with a simpler solution. We do not really need to take care of all possible version number formats, after all, just the ones we use in Git for Windows (and in What do you think about my alternative solution? (I force-pushed it to your branch so that it is easier to compare the two.) |
There was a problem hiding this comment.
@dscho I like yours better! Much cleaner, thanks. I'll rebase.
| done | ||
| } | ||
|
|
||
| test "--test-version-compare" != "$*" || { |
Nevermind, you already rebased. Thanks! |
|
(duplicated from the merged commit) |
This is not super-important for
git-for-windows/gitbecause it always uses-rcXtext in its pre-releases. However, inmicrosoft/gitwe use regular-versioned tags as prereleases that we hand to dogfooders before promoting that same tag as a full release. This has led to users being prompted for upgrades because their version doesn't match the latest, even though their current version is newer.Always use a version comparison that compares the components carefully. I tested the new
version_comparevery carefully, but am not sure of how to test the change in the second commit.