installer: offer the built-in FSMonitor explicitly as an option #351
Conversation
Instead of using a rather violent term, try to describe better what these options are all about. Signed-off-by: Johannes Schindelin <[email protected]>
|
I will want to have that in -rc2, which I will start preparing now. |
There was a problem hiding this comment.
Had you considered any of these alternative names for the option?
- Enable experimental file system monitor
- Enable experimental built-in FSMonitor
- Enable experimental built-in file system monitor
"FSMonitor" vs spelling out "file system", and/or specifying this is the built-in flavour of FSMonitor (because external fsmonitor support exists today).
LGTM otherwise.
Good points. Do you (as a native speaker) have any preference? |
|
Personally, I'd be in favour of spelling out "file system" and including "built-in". |
|
This is it, then!
|
The built-in FSMonitor was included in Git for Windows v2.31.0 already, but judging from the lack of bug reports, not many users found out about the fact that it exists. Let's change that. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
fsmonitor-as-experimental-option
branch
from
7b06d6b to
b513558
Compare
|
|
|
@mjcheetham thank you for helping me improve this last-minute PR! |
The experimental, built-in file system monitor [is now featured as an experimental option in the installer](#351). Signed-off-by: Johannes Schindelin <[email protected]>
|
I like the spelling out in full. If the checks on showing the experimental pages allow, maybe do add the "(FSMonitor)" abbreviation, as a postscript, so folk realise the link when they read docs and blogs. |
|
It's really narrow what's allowed. Even the code for showing those links is quite the hack. |
It has been simmering in Git for Windows for a full release cycle, now it is time to give it even wider exposure. This is how the page looks at the moment:
We might want to have a link to a verbose description of the built-in FSMonitor (such as a blog post), but I am not aware of any web page to which we could link. Maybe I'll have to blog about it...