Updated Update Install Command to improve silent installation #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command successfully identifies and downloads the update however when it triggers the update it causes a license screen to display which requires user interaction. Therefore the update can't be fully automated. This is due to the installer only using the /SILENT option on the new installer. Let's add also the /VERYSILENT option so that the installer works as expected. Signed-off-by: Leo D'Arcy <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
|
Thank you for your contribution! |
1 task
dscho
added a commit
that referenced
this pull request
Mar 20, 2020
`git update-git-for-windows -y` [now is fully automatable](#279). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #2584. This PR should stop the new installer showing a initial install screen by using the existing installer /VERYSILENT command.
As I was using Visual Studio to make these changes an update to the .gitignore got included to avoid additional visual studio specific settings being included in the repo, I've left the .gitignore change in because I didn't think it would harm anything but can remove if required.
This is my first contribution to git so I've not managed to build and test the code however considering the minor changes I didn't know if this was required. I'll try and have a got at building the updated installer over the weekend.
Please let me know if there are any other changes that are needed to be made (patch note additions etc) and I'll get them done as well
A friendly reminder for new contributors:
What is DCO sign-off? Why is it required?
DCO stands for Developer's Certificate of Origin.
We require all commits to be DCO signed-off in case we need to track down and handle legal and/or technical issues.
To DCO sign-off your commits, you could run the
git-commitcommand with the-soption or just add a line in your commit message in this format:For more information, check out how PRs are checked for DCO sign-off: https://github.com/probot/dco#how-it-works .
Thank you very much.
This change is