Teach the installer to create Cygwin symlinks even in non-US locales #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since git-for-windows#255, we create the `/dev/{fd,stdin,stdout,stderr}` symlinks in the installer explicitly, without relying on Git Bash's initial `post-install` scripts. However, the method chosen to create those (Cygwin-style) symlinks seems to work only in US locales. Let's jump through another hoop and make sure that it works also in non-US locales. The approach implemented in this patch was inspired by https://stackoverflow.com/questions/38617829/writing-binary-file-in-inno-setup This fixes git-for-windows/git#2388 Signed-off-by: Johannes Schindelin <[email protected]>
|
Sadly, I have not heard back from the reporters, but no less than the MSYS2 maintainer themselves helped me verify this. |
dscho
added a commit
that referenced
this pull request
Nov 5, 2019
The `/proc/{stdin,stdout,stderr}` pseudo-symlinks
[are now installed properly even with non-US
locales](#265).
Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes git-for-windows/git#2388.