fix installer's Product Version inconsistency with older versions

[AudricGuerin]

Why: Third-party applications or IT tools must be able to know
if the latest Git version is installed on the system
by means of version number comparisons.

How: Remove platform identifier from the Product Version.

Product Version now displays x.x.x.x instead of x.x.x.windows.x

See git-for-windows/git#2223

Signed-off-by: Audric Guerin [email protected]

[PhilipOakley]

I think this may also need a method for updating the git version --build-options so that when some user makes a report on the main Git mailing list folks can tell if they are talking about Linux version or Windows version , especially if a Linux maint version (.1) becomes confused with the Windows initial version (.1)

(I accept that some users don't know how to report bugs so are missing such info, but let's help those who make an effort..)

[PhilipOakley]

I think this may also need a method for updating the git version --build-options

Maybe add a
OS platform: xxx line

[AudricGuerin]

Only the Product Version of the installer was changed so git version still returns:
git version 2.23.0.windows.1

There is no problem with git-for-windows adding a platform identifier for its internal versioning purposes.
I totally understand why you would need this as I had to do such a thing this year for my company... However, I would not add an app-specific version identifier into the 'Product Version' or 'File Version' of any Windows installers or binaries of the project.

Instead I would write it in a .txt, .xml or .json file as suggested by @dscho here:
git-for-windows/git#2223 (comment)

For example, I would be totally willing to accept a PR that writes the current version in plain text (and in the expected, non-SemVer format) into the top-level directory.

And if you really want a Windows user to access Git internal version identifier through Properties > Details of the installer or Settings > Apps & features, then add it to 'Product Name' as @sendqueery said:
git-for-windows/git#2223 (comment)

If you really want it that badly, change the product name field (which also displays the version for some reason) to something like "Git version x.x.x for Windows". (Sidenote: don't do this, as it's still an unnecessary tag. We know it's Windows software by virtue of the fact that WE'RE INSTALLING A WIN32 BINARY ON WINDOWS.)

And by the way, thank you for redirecting me to the right place, Philip. ;)

[PhilipOakley]

Do you fancy copying some of that clarifying explanation into the commit message so I don't fall into the same traps again... Especially if we have to explain it (our versions vs their single version) to the Linux upstream mail list etc etc.

[AudricGuerin]

I added some remarks into the commit message to clarify that the Product Version of the installer file is the only version identifier affected by this commit.