Candidature : postuler pour un candidat depuis l'espace "Mes candidats" #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
from
dba9517
to
1670526
Compare
EwenKorr
changed the title
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
4 times, most recently
from
fa19835
to
5f62cce
Compare
EwenKorr
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
from
5f62cce
to
9e00177
Compare
EwenKorr
commented
Oct 4, 2024
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
2 times, most recently
from
5cad6b6
to
17d7693
Compare
EwenKorr
commented
Oct 4, 2024
EwenKorr
commented
Oct 4, 2024
EwenKorr
commented
Oct 4, 2024
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
from
17d7693
to
621e398
Compare
EwenKorr
commented
Oct 4, 2024
EwenKorr
commented
Oct 4, 2024
EwenKorr
commented
Oct 4, 2024
EwenKorr
commented
Oct 4, 2024
tonial
reviewed
Oct 4, 2024
tonial
reviewed
Oct 4, 2024
EwenKorr
removed
the
1-recette-jetable
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
7 times, most recently
from
0bbb5f5
to
8a3b6d5
Compare
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
from
dbebc9f
to
0a3b83b
Compare
EwenKorr
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
2 times, most recently
from
2821e15
to
8c8f6f7
Compare
tonial
reviewed
Oct 21, 2024
| querystring.update(kwargs) | ||
| return urlunsplit(parsed._replace(query=querystring.urlencode())) | ||
| querystring.update(cleaned_kwargs) | ||
| return urlunsplit(parsed._replace(query=querystring.urlencode("/"))) |
There was a problem hiding this comment.
J'ai un doute sur ce "/" : avant on passait back_url par le filtre urlencode qui avait bien ce paramètre par défaut, mais je me demande si on ne devrait pas le changer (et utiliser le template tag partout à la place de des {% if back_url %} que j'avais essaimé dans le code).
(pas pour cette PR, plus en tant que refléxion pour un nettoyage future)
There was a problem hiding this comment.
J'ai cru remarquer que la gestion de l'encodage des URLs dans les templates mérite un peu de nettoyage en effet.
Django 5.1 avec son nouveau template tag querystring tombe à point nommé (cf #4943)
itou/templates/companies/includes/_list_siae_actives_jobs_row.html
Outdated
Show resolved
Hide resolved
tonial
approved these changes
Oct 21, 2024
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
2 times, most recently
from
6549146
to
61177f2
Compare
- added a link in job seekers list ("Mes candidats")
and in job seeker details page to apply in the
name of a specific job seeker
- all the links up to `apply:start` have been updated
with a GET param (`job_seeker={public_id}`), this
allows to keep track of the job seeker we are
applying for
- when a `job_seeker` GET param is present, and when
the current `user` is allowed to, an alert is
displayed at the top of the page to remind that
we're applying for this job seeker
When visiting `apply:start`, if a job_seeker GET param is set, go directly to ApplicationJobsView
EwenKorr
force-pushed
the
ewen/postuler-mes-candidats
branch
from
61177f2
to
9e968ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
ETQU, lorsque je clique sur le bouton postuler depuis une ligne de la liste candidat ou depuis une page de détail d’un candidat,
je peux faire une recherche d’emploi et postuler sans avoir à renseigner l’adresse e-mail, le NIR du candidat ou les informations personnelles du candidat.
🍰 Comment ?
On passe l'identifiant public du candidat en paramètre
GET(job_seeker=UUID).Une mixin permet d'ajouter aux vues utilisées la variable
job_seekerdans le contexte, si l'utilisateur connecté a la permission (user.can_view_personal_info). Quand cette variable existe, les URLs utilisées contiennent paramètreGET, et un bandeau d'information rappelle que l'on postule pour un candidat.🚨 À vérifier
🏝️ Comment tester
En tant que prescripteur : aller sur Candidats > Postuler pour ce candidat.
En tant qu'employeur(-orienteur) (ETTI Une nouvelle chance dans les données de démo) :
Bloc Orientation (sur le tableau de bord) > Candidats > cliquer sur le nom du candidat pour aller sur sa fiche > Postuler pour ce candidat.
💻 Captures d'écran