Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performances: Utilisation de Brevo à la place de Mailjet pour la gestion de campagnes mails #4742

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Performances: Utilisation de Brevo à la place de Mailjet pour la gestion de campagnes mails #4742

merged 1 commit into from
Oct 3, 2024

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Sep 13, 2024

🤔 Pourquoi ?

Indiquez le problème que nous sommes en train de résoudre et les objectifs métiers ou techniques qui sont visés par ces changements.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial self-assigned this Sep 13, 2024
@notion-workspace Notion Workspace
Copy link

📬 Transition mailing lists MailJet → Brevo

@tonial tonial changed the title Performances: Utilisation de Brevo à la place de Mailjet pour la gestion de campagnes mails [GEN-1542] Performances: Utilisation de Brevo à la place de Mailjet pour la gestion de campagnes mails Sep 13, 2024
@tonial tonial force-pushed the alaurent/brevo branch 3 times, most recently from f8a89c5 to 2b2117c Compare September 16, 2024 04:20
leo-naeka
leo-naeka reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@leo-naeka leo-naeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mailjet ne devait pas avoir de SDK python, Brevo oui…

Je suis partagé entre garder un truc simple pour les seuls endpoints qu'on utilise de leur API et se reposer sur leur SDK, qui semble malgré tout bien testé.

itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/brevo branch 3 times, most recently from ece0732 to a012049 Compare September 18, 2024 04:23
francoisfreitag
francoisfreitag reviewed Sep 18, 2024
View reviewed changes
config/settings/base.py Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Show resolved Hide resolved
itou/users/management/commands/new_users_to_brevo.py Outdated Show resolved Hide resolved
francoisfreitag
francoisfreitag reviewed Sep 19, 2024
View reviewed changes
itou/users/management/commands/new_users_to_brevo.py
users = (
User.objects.filter(kind__in=[UserKind.PRESCRIBER, UserKind.EMPLOYER])
.filter(
# Someday only filter on identity_provider ?
Copy link
Contributor

@francoisfreitag francoisfreitag Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très bonne remarque, comme on force les nouveaux utilisateurs à utiliser un SSO, on peut prévoir de retirer le Exists(EmailAddress) juste après la première exécution de cette commande (qui permettra d’avoir tout de même les utilisateurs qui ne se sont pas connectés depuis 1 an, mais qui étaient dans Mailjet 😮‍💨). D’ici à ce qu’on migre à nouveau les campagnes de comm’, on pourra complètement oublier que les utilisateurs pro se sont un jour connectés via allauth.

@tonial tonial force-pushed the alaurent/brevo branch 3 times, most recently from 6a374a7 to d7e339f Compare September 19, 2024 13:53
francoisfreitag
francoisfreitag approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@tonial tonial force-pushed the alaurent/brevo branch 3 times, most recently from a333aac to 4fa9d67 Compare September 26, 2024 07:00
@tonial tonial force-pushed the alaurent/brevo branch 5 times, most recently from e97138e to 43cb04d Compare September 30, 2024 09:04
@francoisfreitag
Copy link
Contributor

Il faudra penser à mettre un monitor Sentry (cf https://itou.sentry.io/crons/les-emplois-prod/new-users-to-mailjet/?project=6164438&statsPeriod=7d)

@tonial tonial force-pushed the alaurent/brevo branch 2 times, most recently from 58558a2 to 7e8b2a8 Compare October 2, 2024 04:49
@tonial tonial added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 22dfb9f Oct 3, 2024
11 checks passed
@tonial tonial deleted the alaurent/brevo branch October 3, 2024 07:22
@notion-workspace Notion Workspace
Copy link

📬 Transition mailing lists MailJet → Brevo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-naeka leo-naeka leo-naeka left review comments

@xavfernandez xavfernandez xavfernandez left review comments

@francoisfreitag francoisfreitag francoisfreitag approved these changes

Assignees

@tonial tonial

Labels
modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonial @francoisfreitag @leo-naeka @xavfernandez