Employeur: : Modification du message d'erreur sur le SIRET lors de la création d'antenne #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
changed the title
tonial
force-pushed
the
alaurent/siret_message
branch
from
ef5d288
to
9547c3c
Compare
EwenKorr
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Ça m'a l'air ok !
TIL : utiliser la structure ("string1 " "string2") à la place des triples guillemets. Merci !
Et sinon je vois que le test utilise unittest. L'idée est de passer à pytest, c'est ça ?
(je suis tombé sur ça https://www.notion.so/plateforme-inclusion/Migrations-en-cours-98bf5e51fcb64d8ea9e32bccc3456dac#e1265a21885a4c3badddb4b743415a04)
francoisfreitag
changed the title
|
J'ai déjà passé plein de tests à pytest, mais je ne veux pas le faire au sein de PRs de ce style :) |
francoisfreitag
approved these changes
Sep 10, 2024
| "en précisant votre numéro de SIRET (si existant)," | ||
| " le type et l’adresse de cette structure, ainsi que votre numéro de téléphone" | ||
| " pour être contacté(e) si nécessaire." | ||
| external_link = get_external_link_markup( |
There was a problem hiding this comment.
Cet auxiliaire me semble dangereux (parce qu’il mark_safe, sans escape le texte). Mais bon, pour le moment on ne passe que des chaînes sûres. J’aurais tendance à le supprimer. Mais pas nécessaire pour cette PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran