-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-129] UX/UI: page nouveautés #4562
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/[email protected]) |
f70657f
to
e3938ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça marche plutôt bien chez moi, une bonne première version. 👏
Il faudra passer un coup de --snapshot-update
:
Deleted TestNewsRender.test_campaign_rendered_dashboard (tests/www/news/snapshots/test_views.ambr)
@calummackervoy Y a-t-il une carte notion et un figma associé à cette PR ? Si oui, je veux bien les urls. Merci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calummackervoy J'ai pushé un petit commit d'adaptation ui.
Aussi, je pense qu'il manque le lien "Retour" dans le {% block title_prevstep %}
6f8e21b
to
7ae3a66
Compare
9d6e162
to
9731a93
Compare
9731a93
to
58dda1b
Compare
58dda1b
to
c5242cc
Compare
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça devient très agréable à utiliser 👍
tests/www/news/test_views.py
Outdated
assert len(response.context["news_page"]) == 1 | ||
assert response.context["news_page"][0] == campaign | ||
|
||
@pytest.mark.ignore_unknown_variable_template_error("boost_target", "boost_indicator") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N’ignorons pas les erreurs dans du nouveau code. La mark
est présente pour avoir une baseline sur le code écrit avec qu’on ne soit capable de vérifier que toutes les variables d’un template étaient définies.
@pytest.mark.ignore_unknown_variable_template_error("boost_target", "boost_indicator") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK ! Merci 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense que j'ai besoin de cela ; sans le j'ai un erreur Undefined template variable 'boost'
mais on n'utilise que {% if boost %}
donc c'est valide :S
Je l'ai copié de la classe TestApprovalsListView
et j'imagine qu'il était conçu en réponse à ce problème
c5242cc
to
46515d6
Compare
46515d6
to
34cecc2
Compare
34cecc2
to
4111d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça m’a l’air très pratique à utiliser !
Quelques petites remarques à corriger et je pense qu’on sera bons pour le rendre disponible 🎯
itou/templates/news/news.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si on souhaite pousser le vice (et améliorer la cohérence avec les noms des modèles), on pourrait aussi renommer ce template et le module de www
. Comme tu préfères.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'étais entre deux esprits sur le nom annonce plus générique et news qui comporte mieux nos besoins courrants. Enfin j'ai réorganisé ces noms pour être plus logique. J'ai donc bougé la page à /announcements/news/
. Un jour ça pourrait arriver que l'appli announcements
héberge les autres utilisations et l'idée se vindiquera 🤞
La CI est corrigée avec #4626 |
4111d88
to
d942208
Compare
6ba18f4
to
0315a07
Compare
J’ai ajouté une mini modif du markup pour essayer d’améliorer la sémantique de la page, |
Que je viens de revert, car on ne peut pas mettre de heading dans un bouton. Laissons tel quel. |
Ça m’a l’air top 💯 ! |
@francoisfreitag j'attends que ton PR le #4659 et on peut le merger 🎉 la recette jetable a été validée |
dd63df2
to
69c7f71
Compare
feat(communications): render news modal on first device visit feat(communications/admin): AnnouncementCampaign admin and validation fix(AnnouncementCampaignAdminForm): modifying date range feat(communications): render news modal on first device visit feat(communications): implemented a cache for AnnouncementCampaign greatly restricts database usage refactor(CommunicationsConfig): django signals safe to import at module level refactor(communications): model changes requested in feedback refactor(communications): implemented requested cache changes fix: make quality fix(static): delete unused image file refactor(communications): cache changes, added live field feat(communications): render news modal on first device visit feat(communications/admin): AnnouncementCampaign admin and validation fix(AnnouncementCampaignAdminForm): modifying date range feat(communications): render news modal on first device visit feat(communications): implemented a cache for AnnouncementCampaign greatly restricts database usage refactor(communications): implemented requested cache changes feat(communications): news item model fields, admin and form WIP: page nouveautés feat(news.html): styling for news items fix: merge error requirements: merge errors fix: test and code quality feat(news): limit candidate news to relevant news only feat(news.html): collapse icon on monthly news summaries fix: rebase errors feat: links to news page fix: code quality fix(tests): reset_model_sequence for snapshot fix: some ui adjusments refactor(communications/admin.py): change import style refactor(communications/forms.py): relying more on Python core feat(communications/models.py): alt_text field, other model changes refactor(configure_bucket): more concise version of configuration WIP: diverse requested changes feat(news): pagination refactor: enhance testing fix(settings): more specific addition to CSP_IMG_SRC policy fix: tests fix: tests fix: content policy fix: conflict fix: link to news in header content fix: quality fix(news): standardise image height fix(AnnouncementItemForm): restrict user_kind_tags following the spec refactor: requested changes fix: quality error fix: test failure on pipeline refactor: requested changes refactor: consistent naming convention on news fix: rebase mistake minor fixes fix: quality fix: CSS classes, comments Precise new headings and subheadings for improved HTML semantic Revert "Precise new headings and subheadings for improved HTML semantic" This reverts commit e9b09f7. Actually, headings aren’t allowed under button. Let’s leave it at that. minor adjustments fix: import
69c7f71
to
c1e695b
Compare
🤔 Pourquoi ?
Aujourd’hui, le seul espace qui permet de connaitre les modifications et nouveautés se trouve dans le journal de modifications, qui n’est pas du tout digeste pour un utilisateur.
Offrons à nos utilisateurs un espace qui regroupe chaque mois les fonctionnalités qui ont été ajoutées / modifiées
🍰 Comment ?
/news/
🚨 À vérifier
💻 Captures d'écran
Modification dans le site admin :