Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibilité: toujours inclure un texte pour les boutons copier-coller #4550

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

xavfernandez
Copy link
Contributor

@xavfernandez xavfernandez commented Aug 12, 2024

🤔 Pourquoi ?

Pour que les boutons soient plus accessibles (l’icône étant aria-hidden=True)

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

Since the icon is aria-hidden, the button needs to have a content.
Copy link
Contributor

@hellodeloo hellodeloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xavfernandez xavfernandez added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 5aae967 Aug 13, 2024
11 checks passed
@xavfernandez xavfernandez deleted the xfernandez/copy_to_clipboard branch August 13, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants