Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PASS IAE: modification des règles d'affichage de l'encart #4386

Merged
merged 4 commits into from
Jul 9, 2024
Merged

PASS IAE: modification des règles d'affichage de l'encart #4386

merged 4 commits into from
Jul 9, 2024

Conversation

xavfernandez
Copy link
Contributor

🤔 Pourquoi ?

Cela semble plus logique (et plus simple).

  • On utilise désormais l'origine du PASS et non celle de la candidature pour afficher le texte Ce PASS IAE a été importé depuis un agrément Pôle emploi.
  • Affichage systématique de la date de fin prévisionnelle, sauf:
    • pour le parcours de candidature/d'embauche
    • l'acceptation d'une candidature

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@xavfernandez xavfernandez self-assigned this Jul 8, 2024
@xavfernandez xavfernandez force-pushed the xfernandez/use_approval_origin branch from 43fbd06 to a00ac41 Compare July 8, 2024 09:03
tonial
tonial approved these changes Jul 8, 2024
View reviewed changes
itou/templates/approvals/detail.html Outdated Show resolved Hide resolved
@xavfernandez
approval: directly use the approval's origin
5b9ddba 
instead of the job_application that is unlikely to be the one used to
create the approval
@xavfernandez
approval: simplify code
7ab0c56 
get_job_application returns an accepted job_application that cannot be
pending
@xavfernandez
approval: always provide hiring_pending
597bea4 
- for apply/submit views, it's always True since the user is either
  reviewing/submitting a job application or directly hiring an employee
- for approval views, it's always False
@xavfernandez
approval: always use request to access the user
4feec28
@xavfernandez xavfernandez force-pushed the xfernandez/use_approval_origin branch from a00ac41 to 4feec28 Compare July 8, 2024 09:41
@xavfernandez xavfernandez added this pull request to the merge queue Jul 9, 2024
Merged via the queue into master with commit 0b12e55 Jul 9, 2024
11 checks passed
@xavfernandez xavfernandez deleted the xfernandez/use_approval_origin branch July 9, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonial tonial tonial approved these changes

@rsebille rsebille Awaiting requested review from rsebille

Assignees

@xavfernandez xavfernandez

Labels
modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavfernandez @tonial